fix(auth): return clear error on missing auth header and handle configurable tus sign path - #1342
Open
Adityakk9031 wants to merge 1 commit into
Open
Conversation
…igurable tus sign path
Author
|
@ferhatelmas have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix / Developer Experience improvement
What is the current behavior?
Closes #1268
Authorizationheader, the JWT authentication plugin (src/http/plugins/jwt.ts) extracted an empty string""and attempted to verify it withjose.jwtVerify. This causedjoseto throw an internalJWSInvalid: Invalid Compact JWSparsing error instead of an explicit error indicating that the authorization header is missing.src/http/routes/tus/lifecycle.ts, the signed URL check was hardcoded to/upload/resumable/signrather than using the configuredtusPathandSIGNED_URL_SUFFIXconstants.What is the new behavior?
jwtPluginnow checks for missingjwtand returnsERRORS.AccessDenied('Missing authorization header')instead of querying the database for JWT secrets and invokingverifyJWTwith an empty string.lifecycle.tsusestusPathandSIGNED_URL_SUFFIXconstants to support configured TUS URL paths in addition to the default/upload/resumable/sign.