Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

棋譜情報に「記録係」を追加 #953

Merged
merged 1 commit into from
Sep 6, 2024
Merged

棋譜情報に「記録係」を追加 #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/common/i18n/locales/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ export const en: Texts = {
note: "Note",
senteShortName: "Sente(short)",
goteShortName: "Gote(short)",
scorekeeper: "Scorekeeper",
opusNo: "Opus No.",
opusName: "Opus Name",
publishedBy: "Published By",
Expand Down
1 change: 1 addition & 0 deletions src/common/i18n/locales/ja.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ export const ja: Texts = {
note: "備考",
senteShortName: "先手省略名",
goteShortName: "後手省略名",
scorekeeper: "記録係",
opusNo: "作品番号",
opusName: "作品名",
publishedBy: "発表誌",
Expand Down
1 change: 1 addition & 0 deletions src/common/i18n/locales/vi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ export const vi: Texts = {
note: "Ghi chú",
senteShortName: "Tiên thủ (ngắn)",
goteShortName: "Hậu thủ (ngắn)",
scorekeeper: "記録係", // TODO: translate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of scorekeeper key approved but requires translation.

The addition of the scorekeeper key aligns with the PR's objectives. However, the value "記録係" is in Japanese, which suggests it needs translation to Vietnamese. Please address the TODO comment by providing a translation or confirming if the placeholder should remain as is.

opusNo: "Số hiệu",
opusName: "Tên tác phẩm",
publishedBy: "Xuất bản bởi",
Expand Down
1 change: 1 addition & 0 deletions src/common/i18n/locales/zh_tw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ export const zh_tw: Texts = {
note: "備註",
senteShortName: "先手省略名",
goteShortName: "後手省略名",
scorekeeper: "記録係", // TODO: translate
opusNo: "作品編號",
opusName: "作品名",
publishedBy: "發表於",
Expand Down
2 changes: 2 additions & 0 deletions src/common/i18n/record.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ export function getRecordMetadataName(key: RecordMetadataKey): string {
return t.senteShortName;
case RecordMetadataKey.WHITE_SHORT_NAME:
return t.goteShortName;
case RecordMetadataKey.SCOREKEEPER:
return t.scorekeeper;
case RecordMetadataKey.OPUS_NO:
return t.opusNo;
case RecordMetadataKey.OPUS_NAME:
Expand Down
1 change: 1 addition & 0 deletions src/common/i18n/text_template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ export type Texts = {
note: string;
senteShortName: string;
goteShortName: string;
scorekeeper: string;
opusNo: string;
opusName: string;
publishedBy: string;
Expand Down