棋譜情報に「記録係」を追加 #953
棋譜情報に「記録係」を追加 #953
Conversation
WalkthroughThe changes introduce a new localization entry for "scorekeeper" across multiple language files, including English, Japanese, Vietnamese, and Chinese (Traditional). Additionally, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 106 106
Lines 10918 10918
Branches 1963 1963
=======================================
Hits 7806 7806
Misses 3094 3094
Partials 18 18 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (6)
- src/common/i18n/locales/en.ts (1 hunks)
- src/common/i18n/locales/ja.ts (1 hunks)
- src/common/i18n/locales/vi.ts (1 hunks)
- src/common/i18n/locales/zh_tw.ts (1 hunks)
- src/common/i18n/record.ts (1 hunks)
- src/common/i18n/text_template.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- src/common/i18n/locales/en.ts
- src/common/i18n/locales/zh_tw.ts
Additional comments not posted (3)
src/common/i18n/record.ts (1)
50-51: Approved: Addition of SCOREKEEPER case in getRecordMetadataName.The implementation of the new case for
RecordMetadataKey.SCOREKEEPERis consistent with the existing structure and coding style of the switch statement. The use oft.scorekeeperassumes that the translation setup is correctly handled, which should be verified in the corresponding translation files.src/common/i18n/text_template.ts (1)
386-386: Approved: Addition of scorekeeper property to Texts type.The addition of the
scorekeeperproperty to theTextstype is correctly implemented and aligns with the structure of the existing properties. This change supports the new functionality of handling scorekeeper data in different languages.src/common/i18n/locales/ja.ts (1)
391-391: Approved: Addition of scorekeeper translation in Japanese locale.The new translation entry for
scorekeeperas "記録係" is appropriately added to the Japanese locale file. This aligns with the internationalization efforts and supports the new functionality introduced in the application.
| @@ -388,6 +388,7 @@ export const vi: Texts = { | |||
| note: "Ghi chú", | |||
| senteShortName: "Tiên thủ (ngắn)", | |||
| goteShortName: "Hậu thủ (ngắn)", | |||
| scorekeeper: "記録係", // TODO: translate | |||
There was a problem hiding this comment.
Addition of scorekeeper key approved but requires translation.
The addition of the scorekeeper key aligns with the PR's objectives. However, the value "記録係" is in Japanese, which suggests it needs translation to Vietnamese. Please address the TODO comment by providing a translation or confirming if the placeholder should remain as is.
説明 / Description
sunfish-shogi/tsshogi#24
チェックリスト / Checklist
npm testpassednpm run lintwas applied without warnings/docs/webappnot included (except release branch)console.lognot included (except script file)Summary by CodeRabbit
New Features
Documentation
Textstype to include a new property for scorekeeper, aiding in internationalization efforts.