Skip to content

Conversation

@suketa
Copy link
Owner

@suketa suketa commented Nov 13, 2025

Summary by CodeRabbit

  • Chores
    • Updated DuckDB to version 1.4.2 in CI test workflows
    • Updated test configuration to support the new DuckDB version

@coderabbitai
Copy link

coderabbitai bot commented Nov 13, 2025

Walkthrough

CI workflows updated to test against DuckDB 1.4.2 instead of 1.4.1 across macOS, Ubuntu, and Windows platforms. Test skip condition expanded to include version 1.4.2. Changelog entry added documenting the version bump.

Changes

Cohort / File(s) Summary
CI workflow version updates
.github/workflows/test_on_macos.yml, .github/workflows/test_on_ubuntu.yml, .github/workflows/test_on_windows.yml
DuckDB version bumped from 1.4.1 to 1.4.2 in job matrix configurations
Test skip condition
test/duckdb_test/database_test.rb
Expanded skip condition in test_s_open_with_config to exclude DuckDB versions 1.4.0, 1.4.1, and 1.4.2 (previously 1.4.0 and 1.4.1 only)
Changelog
CHANGELOG.md
Added entry under Unreleased section: "bump duckdb to 1.4.2 on CI"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Homogeneous changes: identical version update pattern repeated uniformly across three workflow files
  • Single-line changelog addition
  • Straightforward test skip condition extension with no logic complexity

Possibly related PRs

Poem

🐰 A bunny hops through workflows bright,
Bumping versions left and right,
From 1.4.1 to 1.4.2,
Testing skips updated too!
CI pipelines dance with glee,
Version harmony! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'bump duckdb 1.4.2' accurately reflects the primary change across all modified files—updating DuckDB from version 1.4.1 to 1.4.2 in CI workflows and tests.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump_duckdb_1.4.2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63e56b8 and 44a50c2.

📒 Files selected for processing (5)
  • .github/workflows/test_on_macos.yml (1 hunks)
  • .github/workflows/test_on_ubuntu.yml (1 hunks)
  • .github/workflows/test_on_windows.yml (1 hunks)
  • CHANGELOG.md (1 hunks)
  • test/duckdb_test/database_test.rb (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-01-24T22:37:32.786Z
Learnt from: suketa
Repo: suketa/ruby-duckdb PR: 0
File: :0-0
Timestamp: 2025-01-24T22:37:32.786Z
Learning: In Ruby-DuckDB C extensions, when initializing resources like prepared statements, store them directly in the context structure instead of using temporary variables to prevent memory leaks, especially when exceptions might be thrown.

Applied to files:

  • CHANGELOG.md
📚 Learning: 2025-01-24T22:18:24.630Z
Learnt from: suketa
Repo: suketa/ruby-duckdb PR: 0
File: :0-0
Timestamp: 2025-01-24T22:18:24.630Z
Learning: When using ruby-asan (AddressSanitizer), avoid letting DuckDB throw C++ exceptions by checking conditions (like table existence) beforehand and raising Ruby exceptions directly to prevent ASAN from intercepting the C++ exceptions.

Applied to files:

  • CHANGELOG.md
  • test/duckdb_test/database_test.rb
📚 Learning: 2025-01-26T00:37:44.001Z
Learnt from: suketa
Repo: suketa/ruby-duckdb PR: 871
File: ext/duckdb/appender.c:170-178
Timestamp: 2025-01-26T00:37:44.001Z
Learning: In ruby-duckdb's DuckDB::Appender#append_uint8, values larger than uint8 max (255) are silently truncated to maintain backward compatibility, following C's implicit truncation behavior. Range checking is intentionally omitted to avoid breaking changes.

Applied to files:

  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: test (3.3.10, 1.3.2)
  • GitHub Check: test (3.4.7, 1.4.2)
  • GitHub Check: test (head, 1.3.2)
  • GitHub Check: test (3.5.0-preview1, 1.3.2)
  • GitHub Check: test (3.2.9, 1.3.2)
🔇 Additional comments (5)
.github/workflows/test_on_ubuntu.yml (1)

19-19: LGTM! DuckDB version updated to 1.4.2.

The matrix configuration correctly updates the DuckDB version from 1.4.1 to 1.4.2 for CI testing.

CHANGELOG.md (1)

8-8: LGTM! Changelog entry added.

The changelog correctly documents the DuckDB version bump to 1.4.2 in the CI environment.

.github/workflows/test_on_windows.yml (1)

19-19: LGTM! DuckDB version updated to 1.4.2.

The matrix configuration correctly updates the DuckDB version from 1.4.1 to 1.4.2 for Windows CI testing, consistent with the other platform workflows.

.github/workflows/test_on_macos.yml (1)

19-19: LGTM! DuckDB version updated to 1.4.2.

The matrix configuration correctly updates the DuckDB version from 1.4.1 to 1.4.2 for macOS CI testing, completing the consistent update across all three platform workflows.

test/duckdb_test/database_test.rb (1)

42-42: Verify the rationale for config test skip in DuckDB 1.4.x versions.

The web search found no public breaking bug or report for the config key (default_order or general config) in the DuckDB 1.4.0 → 1.4.2 LTS series. However, the code explicitly skips the config test for these versions, suggesting either an internal issue or a preventive measure.

Before merging, confirm:

  • Whether there's an internal issue tracker or regression documented for the config test failure in 1.4.2
  • Whether the skip condition is still necessary for 1.4.2 or can be narrowed to 1.4.0–1.4.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@suketa suketa merged commit 7f172b5 into main Nov 14, 2025
38 checks passed
@suketa suketa deleted the bump_duckdb_1.4.2 branch November 14, 2025 11:03
This was referenced Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants