Skip to content

Conversation

@suketa
Copy link
Owner

@suketa suketa commented Mar 15, 2025

use duckdb v1.2.1 on CI.

Summary by CodeRabbit

  • Chores
    • Upgraded the database dependency version in the testing configurations across multiple platforms.
  • Documentation
    • Updated the changelog to reflect the dependency version bump.

@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2025

Walkthrough

The pull request updates the DuckDB dependency version in three GitHub Actions workflow files for macOS, Ubuntu, and Windows, changing the version from 1.2.0 to 1.2.1 while leaving other versions intact. Additionally, the CHANGELOG has been updated to reflect this bump. No changes were made to the workflow logic or public declarations.

Changes

File(s) Change Summary
.github/workflows/test_on_macos.yml
.github/workflows/test_on_ubuntu.yml
.github/workflows/test_on_windows.yml
Updated DuckDB version from 1.2.0 to 1.2.1 in the CI job matrices; other versions remain unchanged.
CHANGELOG.md Added an entry noting the bump of DuckDB to v1.2.1 while retaining the dropped 1.0.0 reference.

Possibly related PRs

Poem

I'm a rabbit hopping with delight,
Upgrading DuckDB to a version just right,
CI workflows now bounce to 1.2.1,
Leaving the old version far behind in the sun,
My whiskers twitch with joyful cheer,
In a code garden where updates appear,
Hoppin' on, I celebrate this change with a smile!
(_/) (•_•) (^•ω•^)

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 732d43e and a530c94.

📒 Files selected for processing (4)
  • .github/workflows/test_on_macos.yml (1 hunks)
  • .github/workflows/test_on_ubuntu.yml (1 hunks)
  • .github/workflows/test_on_windows.yml (1 hunks)
  • CHANGELOG.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (18)
  • GitHub Check: test (head, 1.2.1)
  • GitHub Check: test (3.1.6, 1.1.3)
  • GitHub Check: test (3.1.6, 1.2.1)
  • GitHub Check: test (ucrt, 1.1.1)
  • GitHub Check: test (mingw, 1.2.1)
  • GitHub Check: test (mingw, 1.1.3)
  • GitHub Check: test (3.2.6, 1.1.3)
  • GitHub Check: test (3.4.1, 1.1.3)
  • GitHub Check: test (3.3.6, 1.1.1)
  • GitHub Check: test (3.1.6, 1.2.1)
  • GitHub Check: test (3.4.1, 1.2.1)
  • GitHub Check: test (3.3.6, 1.1.3)
  • GitHub Check: test (3.2.6, 1.2.1)
  • GitHub Check: test (head, 1.1.3)
  • GitHub Check: test (head, 1.1.1)
  • GitHub Check: test (3.2.6, 1.2.1)
  • GitHub Check: test (3.2.6, 1.1.1)
  • GitHub Check: test (3.1.6, 1.1.1)
🔇 Additional comments (4)
.github/workflows/test_on_ubuntu.yml (1)

19-19: Updated DuckDB Version in Ubuntu Workflow:
The matrix now specifies duckdb: ['1.2.1', '1.1.3', '1.1.1'], correctly updating the default DuckDB version from 1.2.0 to 1.2.1 as per the PR objective. Please ensure that any downstream steps consuming this version (e.g. build and cache steps) continue to operate as expected with 1.2.1.

.github/workflows/test_on_windows.yml (1)

19-19: Updated DuckDB Version in Windows Workflow:
The updated matrix entry duckdb: ['1.2.1', '1.1.3', '1.1.1'] now reflects the new DuckDB version 1.2.1. Make sure that the download URL and subsequent steps (e.g. downloading the Windows binary) are compatible with this version.

.github/workflows/test_on_macos.yml (1)

19-19: Updated DuckDB Version in macOS Workflow:
The job matrix now lists duckdb: ['1.2.1', '1.1.3', '1.1.1'], effectively bumping the version to 1.2.1. Please confirm that the build and test commands (especially those involving shared libraries like .dylib) function correctly with the updated version.

CHANGELOG.md (1)

5-5: Changelog Update for DuckDB Version:
The changelog now includes the entry “- bump duckdb v1.2.1 on CI.”, which documents the dependency upgrade in the CI environment. This is consistent with the workflow changes; please verify that the changelog accurately reflects all related updates.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@suketa suketa merged commit 33e4684 into main Mar 15, 2025
58 checks passed
@suketa suketa deleted the bump_duckdb_v1.2.1 branch March 15, 2025 23:40
@coderabbitai coderabbitai bot mentioned this pull request Mar 16, 2025
@coderabbitai coderabbitai bot mentioned this pull request May 11, 2025
@coderabbitai coderabbitai bot mentioned this pull request May 23, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jun 20, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants