Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALPHA PHASE] Prompt Frequency Capping Flow #3189

Merged
merged 70 commits into from
Sep 26, 2023
Merged

[ALPHA PHASE] Prompt Frequency Capping Flow #3189

merged 70 commits into from
Sep 26, 2023

Commits on Sep 15, 2023

  1. log impressions for frequency capping actions

    @justinchou-google
    justinchou-google committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    13cc611 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into impression
    @justinchou-google
    justinchou-google committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    4434ed9 View commit details
    Browse the repository at this point in the history

  3. remove unused consts

    @justinchou-google
    justinchou-google committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ecb76d4 View commit details
    Browse the repository at this point in the history

  4. refactored

    @justinchou-google
    justinchou-google committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    96945dd View commit details
    Browse the repository at this point in the history

  5. add flag guard

    @justinchou-google
    justinchou-google committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0783dfd View commit details
    Browse the repository at this point in the history

  6. add experiment flag

    @justinchou-google
    justinchou-google committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    396dc8d View commit details
    Browse the repository at this point in the history

  7. add tests

    @justinchou-google
    justinchou-google committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f98b606 View commit details
    Browse the repository at this point in the history

  8. add comments

    @justinchou-google
    justinchou-google committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    706a177 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. fix experiment flag

    @justinchou-google
    justinchou-google committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    726065b View commit details
    Browse the repository at this point in the history

  2. add regwall to impressions

    @justinchou-google
    justinchou-google committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    8c0c40e View commit details
    Browse the repository at this point in the history

  3. remove cta check for frequency capping local storage

    @justinchou-google
    justinchou-google committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b83a0cf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into impression
    @justinchou-google
    justinchou-google committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    86699ef View commit details
    Browse the repository at this point in the history

  5. remove deprecated test

    @justinchou-google
    justinchou-google committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    75d244c View commit details
    Browse the repository at this point in the history

  6. reorder expression for clarity

    @justinchou-google
    justinchou-google committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    757e056 View commit details
    Browse the repository at this point in the history

  7. add impression test for regwall

    @justinchou-google
    justinchou-google committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ae65fb5 View commit details
    Browse the repository at this point in the history

  8. add todo for manually triggered prompt

    @justinchou-google
    justinchou-google committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d5b20af View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. rename storage key consts for consistency

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    78b0612 View commit details
    Browse the repository at this point in the history

  2. abbreviate storage keys to imp

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    72b60e5 View commit details
    Browse the repository at this point in the history

  3. clean code

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c3d0116 View commit details
    Browse the repository at this point in the history

  4. refactor tests

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d44ab6a View commit details
    Browse the repository at this point in the history

  5. add new property hasStoredMiniPromptImpression_

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5dad42f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into impression
    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    46563ef View commit details
    Browse the repository at this point in the history

  7. fix tests

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9553a7e View commit details
    Browse the repository at this point in the history

  8. fix experimetn flag to be article experiment

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    73bad07 View commit details
    Browse the repository at this point in the history

  9. move article experiment flag to autopromptmanager, add test for setti… 

    …ng article experiment flag
    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b2e8488 View commit details
    Browse the repository at this point in the history

  10. add mini test

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    dc6b261 View commit details
    Browse the repository at this point in the history

  11. rename setArticleExperimentFlags

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c6f0f45 View commit details
    Browse the repository at this point in the history

  12. save point

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e9de808 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into trigger
    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4b0b07a View commit details
    Browse the repository at this point in the history

  14. merge conflict

    @justinchou-google
    justinchou-google committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    de0907b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. save point

    @justinchou-google
    justinchou-google committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f1c2cc9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into trigger
    @justinchou-google
    justinchou-google committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    94958d7 View commit details
    Browse the repository at this point in the history

  3. add docstring comments

    @justinchou-google
    justinchou-google committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    48c86f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. update survey local storage in tests

    @justinchou-google
    justinchou-google committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    804a461 View commit details
    Browse the repository at this point in the history

  2. add experiment flag to legaacy triggering flow checks

    @justinchou-google
    justinchou-google committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    26bae46 View commit details
    Browse the repository at this point in the history

  3. expand duration proto to seconds and nano

    @justinchou-google
    justinchou-google committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    842ef0b View commit details
    Browse the repository at this point in the history

  4. save point

    @justinchou-google
    justinchou-google committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c28ffea View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. save point on tests

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e0a5be4 View commit details
    Browse the repository at this point in the history

  2. more tests

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    16b3a8e View commit details
    Browse the repository at this point in the history

  3. add full tests

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    98b0d19 View commit details
    Browse the repository at this point in the history

  4. bug fixes

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0dfbc7c View commit details
    Browse the repository at this point in the history

  5. units

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    094205d View commit details
    Browse the repository at this point in the history

  6. remove old code

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    5b628bc View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into trigger
    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d4039ee View commit details
    Browse the repository at this point in the history

  8. add test

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a2b95c6 View commit details
    Browse the repository at this point in the history

  9. fix test

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    daa0267 View commit details
    Browse the repository at this point in the history

  10. add survey eligibility test

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    15100b1 View commit details
    Browse the repository at this point in the history

  11. rename test group

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    fba1916 View commit details
    Browse the repository at this point in the history

  12. fix survey action check

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    78e6d90 View commit details
    Browse the repository at this point in the history

  13. add test for isactionpromptwithdelay with experiment disabled

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    33fc310 View commit details
    Browse the repository at this point in the history

  14. adjust test for code coverage

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ec62a96 View commit details
    Browse the repository at this point in the history

  15. fix test

    @justinchou-google
    justinchou-google committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    46e892b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into trigger
    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e92d0f3 View commit details
    Browse the repository at this point in the history

  2. split new and legacy flow into two, add todo for missing config

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c1d4f71 View commit details
    Browse the repository at this point in the history

  3. revert

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a36e0c5 View commit details
    Browse the repository at this point in the history

  4. remove deprecated test

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d0c995a View commit details
    Browse the repository at this point in the history

  5. refactor

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c5bea5a View commit details
    Browse the repository at this point in the history

  6. check frequencycapconfig as additional frequency cap flow flag

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1d5de84 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into trigger
    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    5f54979 View commit details
    Browse the repository at this point in the history

  8. added test for empty actions

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7f22334 View commit details
    Browse the repository at this point in the history

  9. add mini prompt test

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    6ab6876 View commit details
    Browse the repository at this point in the history

  10. refactor, rename functions

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    cc7b673 View commit details
    Browse the repository at this point in the history

  11. coverage

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0ffb186 View commit details
    Browse the repository at this point in the history

  12. coverage

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    50098b2 View commit details
    Browse the repository at this point in the history

  13. fix test

    @justinchou-google
    justinchou-google committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    eaa88c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. add comment for different flows

    @justinchou-google
    justinchou-google committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1092f7d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/subscriptions-project/swg-js … 

    …into trigger
    @justinchou-google
    justinchou-google committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b56715a View commit details
    Browse the repository at this point in the history

  3. clean up filter expression with find

    @justinchou-google
    justinchou-google committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    292449d View commit details
    Browse the repository at this point in the history

  4. reduce tick

    @justinchou-google
    justinchou-google committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    45967a9 View commit details
    Browse the repository at this point in the history

  5. restore comment, dummy commit

    @justinchou-google
    justinchou-google committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    dbd0cdc View commit details
    Browse the repository at this point in the history