-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ALPHA PHASE] Prompt Frequency Capping Flow #3189
Merged
justinchou-google
merged 70 commits into
subscriptions-project:main
from
justinchou-google:trigger
Sep 26, 2023
Merged
[ALPHA PHASE] Prompt Frequency Capping Flow #3189
justinchou-google
merged 70 commits into
subscriptions-project:main
from
justinchou-google:trigger
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into impression
…into impression
…into impression
…ng article experiment flag
justinchou-google
requested review from
fikus,
jpettitt,
oyj9109 and
Wayne-X
as code owners
September 22, 2023 22:09
oyj9109
reviewed
Sep 25, 2023
oyj9109
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few more comments for nit, but overall looks really great! I love to see how simple the new logic is, yet it is more capable of.
oyj9109
approved these changes
Sep 26, 2023
LGTM. Thanks for great work! |
justinchou-google
merged commit Sep 26, 2023
1817630
into
subscriptions-project:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/299846493
https://docs.google.com/document/d/1H99mlR47aZZv_ZsCRkI6Iv_WUcpwaoeGgCExWSkdYCI/edit?resourcekey=0-9djhO0eRtzh5bMMrZ1dtBg#heading=h.634013igpqpv
Extends triggering flow to follow new prompt frequency capping. Expands
AutoPromptConfig
model to handleFrequencyCapConfig
. Refactors some action eligibility checks. Also refactors computation of prompt delay. Updates openaccess subscription flow to follow audience action order. Display delay is extended to all dismissible prompts. All changes guarded by experiment flag.TODOs:
actionType
that is not mapped to anImpressionStorageKey
.