Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom vpc support in AWS cloud prepare #1230

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add custom vpc support in AWS cloud prepare #1230

merged 1 commit into from
Sep 25, 2024

Conversation

aswinsuryan
Copy link
Contributor

@aswinsuryan aswinsuryan commented Sep 21, 2024 •
edited by tpantelis
Loading

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1230/aswinsuryan/custom-vpc
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@aswinsuryan aswinsuryan marked this pull request as draft September 21, 2024 03:23
@aswinsuryan aswinsuryan force-pushed the custom-vpc branch 3 times, most recently from 2e112e9 to 5377ca5 Compare September 24, 2024 20:20
@aswinsuryan aswinsuryan marked this pull request as ready for review September 24, 2024 20:28
@aswinsuryan aswinsuryan mentioned this pull request Sep 25, 2024
Closed
5 tasks
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Sep 25, 2024
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@aswinsuryan @tpantelis
Add custom vpc support in AWS cloud prepare
66a1bba 
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
@tpantelis tpantelis enabled auto-merge (rebase) September 25, 2024 18:23
@tpantelis tpantelis merged commit 41e7302 into submariner-io:devel Sep 25, 2024
30 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1230/aswinsuryan/custom-vpc]

@aswinsuryan aswinsuryan mentioned this pull request Sep 26, 2024
Merged
@tpantelis tpantelis mentioned this pull request Sep 26, 2024
Merged
skitt added a commit to aswinsuryan/subctl that referenced this pull request Oct 3, 2024
@skitt
Merge branch 'release-0.16' into automated-backport-of-submariner-io#…
e5bb7f8 
…1230-upstream-release-0.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthapar vthapar vthapar approved these changes

@tpantelis tpantelis tpantelis approved these changes

@dfarrell07 dfarrell07 Awaiting requested review from dfarrell07 dfarrell07 is a code owner

@Jaanki Jaanki Awaiting requested review from Jaanki Jaanki is a code owner

@maayanf24 maayanf24 Awaiting requested review from maayanf24 maayanf24 is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees
No one assigned
Labels
backport-handled ready-to-test When a PR is ready for full E2E testing release-note-handled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aswinsuryan @submariner-bot @vthapar @tpantelis @dfarrell07