Add custom vpc support in AWS cloud prepare #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr1007/aswinsuryan/aws-custom-vpc |
aswinsuryan
force-pushed
the
aws-custom-vpc
branch
22 times, most recently
from
4fd622e
to
00c4f51
Compare
aswinsuryan
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
5 tasks
vthapar
approved these changes
Sep 25, 2024
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com> Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
force-pushed
the
aws-custom-vpc
branch
from
00c4f51
to
cbebff8
Compare
tpantelis
approved these changes
Sep 25, 2024
out.txt
Outdated
| @@ -0,0 +1,443 @@ | |||
| /* | |||
There was a problem hiding this comment.
I assume you didn't mean to submit this file.
pkg/aws/aws.go
Outdated
| type awsCloud struct { | ||
| client awsClient.Interface | ||
| infraID string | ||
| region string | ||
| nodeSGSuffix string | ||
| controlPlaneSGSuffix string | ||
| CloudConfig map[string]interface{} |
There was a problem hiding this comment.
This doesn't need to be public for consistency.
Suggested change
| CloudConfig map[string]interface{} | |
| cloudConfig map[string]interface{} |
| publicSubnets, err = d.aws.findPublicSubnets(vpcID, d.aws.filterByName("{infraID}*-public-{region}*")) | ||
| if err != nil { | ||
| return status.Error(err, "unable to find public subnets") | ||
| } |
There was a problem hiding this comment.
This code block looks the same as the block starting on L152 above except the latter checks for len(publicSubnets). I think we can refactor to a function and let the caller check len(publicSubnets).
pkg/aws/ocpgwdeployer.go
Outdated
Comment on lines
119
to
124
| err = d.processSubnets(vpcID, gatewaySG, publicSubnets, input, status) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Suggested change
| err = d.processSubnets(vpcID, gatewaySG, publicSubnets, input, status) | |
| if err != nil { | |
| return err | |
| } | |
| return nil | |
| return d.processSubnets(vpcID, gatewaySG, publicSubnets, input, status) |
|
🤖 Closed branches: [z_pr1007/aswinsuryan/aws-custom-vpc] |
aswinsuryan
added a commit
to aswinsuryan/submariner-website
that referenced
this pull request
Oct 9, 2024
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom vpc support in AWS cloud prepare