-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate exported Service session affinity to ServiceImport #1621
Conversation
...to align with the MCS spec. If multiple clusters export a service, the fields are merged, ie for SessionAffinity, if any exported service has "ClientIP" then the ServiceImport will as well; for SessionAffinityConfig, the ServiceImport will inherit the first exported non-nil SessionAffinityConfig. Fixes submariner-io#1610 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
🤖 Created branch: z_pr1621/tpantelis/si_session_affinity |
@vthapar @skitt @aswinsuryan I wonder if we should report a conflict condition if all constituent cluster services don't specify the same For |
🤖 Closed branches: [z_pr1621/tpantelis/si_session_affinity] |
Release notes for submariner-io/lighthouse#1621 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Release notes for submariner-io/lighthouse#1621 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
...to align with the MCS spec. If multiple clusters export a service, the fields are merged, ie for
SessionAffinity
, if any exported service hasClientIP
then theServiceImport
will as well; forSessionAffinityConfig
, theServiceImport
will inherit the first exported non-nilSessionAffinityConfig
.Fixes #1610