Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceImports should inherit the SessionAffinity and SessionAffinityConfig from the exported Service #1610

Closed
tpantelis opened this issue Aug 15, 2024 · 0 comments · Fixed by #1621
Closed

ServiceImports should inherit the SessionAffinity and SessionAffinityConfig from the exported Service #1610

tpantelis opened this issue Aug 15, 2024 · 0 comments · Fixed by #1621
Assignees
@tpantelis
Labels
bug Something isn't working mcs-api-alignment Align with MCS API as defined in KEP #1646 priority:medium

Comments

@tpantelis
Copy link
Contributor

Referencing the MSC spec: https://github.com/kubernetes/enhancements/tree/master/keps/sig-multicluster/1645-multi-cluster-services-api#session-affinity. We're not setting these fields on the ServiceImport.
@tpantelis tpantelis added the bug Something isn't working label Aug 15, 2024
@tpantelis tpantelis self-assigned this Aug 15, 2024
@tpantelis tpantelis added the mcs-api-alignment Align with MCS API as defined in KEP #1646 label Aug 20, 2024
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Aug 20, 2024
@tpantelis
Propagate exported Service session affinity to ServiceImport
7019732 
...to align with the MCS spec. If multiple clusters export a
service, the fields are merged, ie for SessionAffinity, if any
exported service has "ClientIP" then the ServiceImport will as well;
for SessionAffinityConfig, the ServiceImport will inherit the first
exported non-nil SessionAffinityConfig.

Fixes submariner-io#1610

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@tpantelis tpantelis mentioned this issue Aug 20, 2024
Merged
tpantelis added a commit that referenced this issue Aug 21, 2024
@tpantelis
Propagate exported Service session affinity to ServiceImport
4d8164a 
...to align with the MCS spec. If multiple clusters export a
service, the fields are merged, ie for SessionAffinity, if any
exported service has "ClientIP" then the ServiceImport will as well;
for SessionAffinityConfig, the ServiceImport will inherit the first
exported non-nil SessionAffinityConfig.

Fixes #1610

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpantelis tpantelis

Labels
bug Something isn't working mcs-api-alignment Align with MCS API as defined in KEP #1646 priority:medium
Projects
Submariner 0.19
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate exported Service session affinity to ServiceImport tpantelis/lighthouse
2 participants
@dfarrell07 @tpantelis