Skip to content

Fix #664 fixing coverage #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Fix #664 fixing coverage #666

merged 3 commits into from
Sep 1, 2022

Conversation

NimaSarajpoor
Copy link
Collaborator

This PR fixes the coverage issue raised in the PR #665, related to issue #664.

@NimaSarajpoor
Copy link
Collaborator Author

@seanlaw
When you notice all tests are passing, you may want to take a look and see if the inline comments are okay or not. I did as follows:

else # pragma: no cover  # AB-join  

I think it fixes the coverage; however, I am not sure if you prefer to remove the second comment # AB-join or not.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #666 (859a3a1) into main (bcc5b02) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   99.87%   99.89%   +0.01%     
==========================================
  Files          80       80              
  Lines       11455    11453       -2     
==========================================
  Hits        11441    11441              
+ Misses         14       12       -2     
Impacted Files Coverage Δ
stumpy/scraamp.py 100.00% <ø> (+0.70%) ⬆️
stumpy/scrump.py 100.00% <ø> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seanlaw
Copy link
Contributor

seanlaw commented Sep 1, 2022

When you notice all tests are passing, you may want to take a look and see if the inline comments are okay or not

Yeah, I noticed it originally and it didn't bother me a ton and I would've done the same thing as you. 😄

@seanlaw seanlaw merged commit 11bb86d into stumpy-dev:main Sep 1, 2022
@seanlaw
Copy link
Contributor

seanlaw commented Sep 1, 2022

Thanks @NimaSarajpoor

@NimaSarajpoor NimaSarajpoor deleted the param_s branch September 4, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants