Skip to content

Commit bcc5b02

Browse files
Fixed #664 param s in AB-join mode (#665)
1 parent d1469aa commit bcc5b02

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

stumpy/scraamp.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -324,8 +324,11 @@ def prescraamp(T_A, m, T_B=None, s=None, p=2.0):
324324
n_A = T_A.shape[0]
325325
l = n_A - m + 1
326326

327-
if s is None: # pragma: no cover
328-
s = excl_zone
327+
if s is None: # pragma: no cover:
328+
if excl_zone is not None: # self-join
329+
s = excl_zone
330+
else: # AB-join
331+
s = int(np.ceil(m / config.STUMPY_EXCL_ZONE_DENOM))
329332

330333
indices = np.random.permutation(range(0, l, s)).astype(np.int64)
331334
P, I = _prescraamp(
@@ -509,9 +512,11 @@ def __init__(
509512
self._I[:, :] = -1
510513

511514
self._excl_zone = int(np.ceil(self._m / config.STUMPY_EXCL_ZONE_DENOM))
512-
513515
if s is None:
514-
s = self._excl_zone
516+
if self._excl_zone is not None: # self-join
517+
s = self._excl_zone
518+
else: # AB-join
519+
s = int(np.ceil(self._m / config.STUMPY_EXCL_ZONE_DENOM))
515520

516521
if pre_scraamp:
517522
if self._ignore_trivial:

stumpy/scrump.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,11 @@ def prescrump(T_A, m, T_B=None, s=None, normalize=True, p=2.0):
339339
n_A = T_A.shape[0]
340340
l = n_A - m + 1
341341

342-
if s is None: # pragma: no cover
343-
s = excl_zone
342+
if s is None: # pragma: no cover:
343+
if excl_zone is not None: # self-join
344+
s = excl_zone
345+
else: # AB-join
346+
s = int(np.ceil(m / config.STUMPY_EXCL_ZONE_DENOM))
344347

345348
indices = np.random.permutation(range(0, l, s)).astype(np.int64)
346349
P, I = _prescrump(
@@ -578,9 +581,11 @@ def __init__(
578581
self._I[:, :] = -1
579582

580583
self._excl_zone = int(np.ceil(self._m / config.STUMPY_EXCL_ZONE_DENOM))
581-
582584
if s is None:
583-
s = self._excl_zone
585+
if self._excl_zone is not None: # self-join
586+
s = self._excl_zone
587+
else: # AB-join
588+
s = int(np.ceil(self._m / config.STUMPY_EXCL_ZONE_DENOM))
584589

585590
if pre_scrump:
586591
if self._ignore_trivial:

0 commit comments

Comments
 (0)