Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alert user if attempting to use methods before initializing Stripe #853

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix: Alert user if attempting to use methods before initializing Stripe #853

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2427f54
fix: add null safety for Stripe API and payment handler iOS
charliecruzan-stripe Mar 18, 2022
febd97e
fix: add null safety for stripe api on Android
charliecruzan-stripe Mar 18, 2022
9045727
fix android build
charliecruzan-stripe Mar 18, 2022
c0df213
fix: use STPAPIClient.shared otherwise stuff breaks
charliecruzan-stripe Mar 18, 2022
6f71827
changelog
charliecruzan-stripe Apr 11, 2022
e4081d2
fix build errors on ios nad android
charliecruzan-stripe Apr 11, 2022
0e1ac56
fix ios build error
charliecruzan-stripe Apr 12, 2022
01bcc3a
add safety to verifyMicrodeposits method
charliecruzan-stripe Apr 18, 2022
c412a28
fix after rebase
charliecruzan-stripe Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use STPAPIClient.shared otherwise stuff breaks
  • Loading branch information
@charliecruzan-stripe
charliecruzan-stripe committed Apr 22, 2022
commit c0df213d6ec6b8d87859b5993ad18610c8d05299
9 changes: 5 additions & 4 deletions ios/StripeSdk.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,11 @@ class StripeSdk: RCTEventEmitter, STPApplePayContextDelegate, STPBankSelectionVi
let url = RCTConvert.nsString(appInfo["url"]) ?? ""

self.merchantIdentifier = merchantIdentifier

self.apiClient = STPAPIClient.init(publishableKey: publishableKey)
self.apiClient?.stripeAccount = stripeAccountId
self.apiClient?.appInfo = STPAppInfo(name: name, partnerId: partnerId, version: version, url: url)

STPAPIClient.shared.publishableKey = publishableKey
STPAPIClient.shared.stripeAccount = stripeAccountId
STPAPIClient.shared.appInfo = STPAppInfo(name: name, partnerId: partnerId, version: version, url: url)
self.apiClient = STPAPIClient.shared

self.paymentHandler = STPPaymentHandler.shared()
self.paymentHandler?.apiClient = self.apiClient!
Expand Down