fix: Alert user if attempting to use methods before initializing Stripe #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliecruzan-stripe
requested review from
ramont-stripe and
skyler-stripe
and removed request for
acomley-stripe
charliecruzan-stripe
force-pushed
the
charliecruzan-null-safety-stripe-api
branch
2 times, most recently
from
7ff677d to
46f4031
Compare
charliecruzan-stripe
force-pushed
the
charliecruzan-null-safety-stripe-api
branch
from
e47e6e4 to
46f359a
Compare
charliecruzan-stripe
force-pushed
the
charliecruzan-null-safety-stripe-api
branch
from
46f359a to
c412a28
Compare
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can no longer make calls with the Stripe API client if it hasn't been initialized yet. Applies the same to the
STPPaymentHandleron iOSMotivation
This will force null checks and make it more difficult to add problematic code in the future.
closes #605
Testing
Some manual testing + CI
Documentation
Select one: