Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark nullable fields in PHPDoc #790

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Mark nullable fields in PHPDoc #790

merged 1 commit into from
Nov 5, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

  • Mark nullable fields in PHPDoc
  • Use fully qualified names everywhere for \Stripe\Collection, \Stripe\StripeObject, etc.

remi-stripe
remi-stripe approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but one minor comment, you added a method so it should get a test

lib/Radar/ValueListItem.php Outdated Show resolved Hide resolved
@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Nov 5, 2019
@stripe-ci stripe-ci removed the approved label Nov 5, 2019
@stripe-ci stripe-ci removed the approved label Nov 5, 2019
@ob-stripe ob-stripe merged commit c1f1a94 into master Nov 5, 2019
@ob-stripe ob-stripe deleted the ob-nullable branch November 5, 2019 18:15
@ob-stripe
Copy link
Contributor Author

Released as 7.8.0.

@ob-stripe ob-stripe mentioned this pull request Nov 5, 2019
Closed
@ruudk
Copy link
Contributor

ruudk commented Nov 5, 2019

Thanks so much 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ob-stripe @ruudk @remi-stripe @stripe-ci