Fix all phpdoc annotations when they can be null

[ruudk]

I'm looking at Card.php:

stripe-php/lib/Card.php

Lines 11 to 18 in b6b8bdd

	* @property string $address_city
	* @property string $address_country
	* @property string $address_line1
	* @property string $address_line1_check
	* @property string $address_line2
	* @property string $address_state
	* @property string $address_zip
	* @property string $address_zip_check

and I see that all these properties are marked as string type. But when I check the documentation, I see that these properties can be either string or null:
https://stripe.com/docs/api/cards/object

Is there a full list of all properties and the nullability? I think it would be good to fix all these properties as they can lead to bugs.

[ruudk]

Looking at https://raw.githubusercontent.com/stripe/openapi/master/openapi/spec3.yaml it should be doable to automatically fix all these issues.

[remi-stripe]

@ruudk tagging as future for now. We're working on auto-generating the client library from the openapi spec (we do already for java, ruby, python and node). Once that is shipped we should be able to add the nullability context to the phpdocs.

Tagging @ob-stripe who is working on this.

[ruudk]

Cool, that seems like the way to go indeed! Is there a PR to track the progress or an ETA on this?

[remi-stripe]

No PR or firm ETA just yet no but it's being worked on internally!

[ruudk]

Would it already be possible that I submit a PR to fix some (10-15) of these issues? I'm running https://psalm.dev/ and it complains a lot.

[remi-stripe]

Hmmm that might conflict with our autogen approach so I'd recommend punting for now. But cc @ob-stripe in case you have more context.

[ob-stripe]

Hi @ruudk. Really appreciate the offer, but as @remi-stripe mentioned I think it might conflict with our own efforts. We'll try to release a fix for this soon. Thanks for your patience!

[ob-stripe]

Fixed in v7.8.0 (by #790). All nullable fields should now be marked as such in PHPDoc.