-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define 'type' as a property on errors rather than a getter #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rattrayalex-stripe
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, yep, this looks cleaner! And yes, type
should definitely be enumerable; oops.
Thanks Richard!
nsallerin
added a commit
to fewlines-education/stripe-demo
that referenced
this pull request
Dec 16, 2019
…ode-dependencies ## Description **react** and **react-dom** updated from **16.9.0 to 16.12.0** ###### React DOM * Remove `unstable_createRoot` and `unstable_createSyncRoot` experimental APIs. (These are available in the Experimental channel as `createRoot` and `createSyncRoot`.) ([@acdlite] * Clear additional fiber fields during unmount to save memory. ([@trueadm](http://github.com/trueadm) in [#16807](facebook/react#16807)) * Prefer `Object.is` instead of inline polyfill, when available. ([@ku8ar](http://github.com/ku8ar) in [#16212](facebook/react#16212)) **react-scripts** updated from **16.9.0 to 16.12.0** https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md **dotenv** updated from **8.1.0 to 8.2.0** https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md ---> no changes in changelog **stripe** updated from **7.9.1 to 7.14.0** - [#699](stripe/stripe-node#699) Add request-specific fields from raw error to top level error - [#719](stripe/stripe-node#719) Define 'type' as a property on errors rather than a getter - [#728](stripe/stripe-node#728) Remove duplicate export ## Related Issue [ch1243] ## Motivation and Context We want our dependencies up to date ## How Has This Been Tested? Running `yarn test` all tests passed ## Types of changes - Chore (non-breaking change which refactors / improves the existing code base) - ~Bug fix (non-breaking change which fixes an issue)~ - ~New feature (non-breaking change which adds functionality)~ - ~Breaking change (fix or feature that would cause existing functionality to change)~ ## Checklist: - ✅ My code follows the code style of this project. - 🔴 My change requires a change to the documentation. - 🔴 I have updated the documentation accordingly. - ✅ I have read the [**CONTRIBUTING**][CONTRIBUTING_FILE] document. - 🔴 I have added tests to cover my changes. - ✅ All new and existing tests passed. [CONTRIBUTING_FILE]: https://github.com/fewlinesco/connect/blob/master/CONTRIBUTING.md
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
Define 'type' as a property on errors rather than a getter
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
Define 'type' as a property on errors rather than a getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rattrayalex-stripe for discussion:
I don't have a full understanding of why it was originally important for 'type' to be implemented as a getter -- or if we should do this -- but this PR both
test/Error.spec.js
outputs
and
outputs the same.