-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize objectIs #16212
Optimize objectIs #16212
Conversation
Native Object.is implementation is much faster than polyfill.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
No significant bundle size changes to report. Generated by 🚫 dangerJS |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@probablyup @intellil OK, I know why so weak. I wrote the wrong test. Safari is very slow when reading the value of the I have improved test and it is much better: No difference on Safari and Firefox, but a great improvement on Chrome. |
@acdlite hi! What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. Thanks for this contribution!
Native Object.is implementation is much faster than polyfill.
https://jsperf.com/object-is-vs-polyfill/1https://jsperf.com/object-is-vs-polyfill-better/1