Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PKAddress warnings #913

Merged
merged 5 commits into from
Mar 20, 2018
Merged

Fix PKAddress warnings #913

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7ab18c
add with_frameworks_objc installation test
bg-stripe Mar 20, 2018
a5c6132
update installation tests
bg-stripe Mar 20, 2018
623c1c0
update .travis.yml
bg-stripe Mar 20, 2018
dbedde0
silence PKAddress deprecation warnings
bg-stripe Mar 20, 2018
da1cbea
move pragma ignores above docstrings
bg-stripe Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ script:
- '[ "$TEST_TYPE" != lint ] || ./ci_scripts/check_fauxpas.sh'
- '[ "$TEST_TYPE" != tests ] || travis_retry ./ci_scripts/run_tests.sh'
- '[ "$TEST_TYPE" != analyzer ] || ./ci_scripts/run_analyzer.sh'
- '[ "$TEST_TYPE" != installation_cocoapods ] || ./Tests/installation_tests/cocoapods/without_frameworks/test.sh'
- '[ "$TEST_TYPE" != installation_cocoapods_frameworks ] || ./Tests/installation_tests/cocoapods/with_frameworks/test.sh'
- '[ "$TEST_TYPE" != installation_cocoapods_objc ] || ./Tests/installation_tests/cocoapods/without_frameworks_objc/test.sh'
- '[ "$TEST_TYPE" != installation_cocoapods_frameworks_objc ] || ./Tests/installation_tests/cocoapods/with_frameworks_objc/test.sh'
- '[ "$TEST_TYPE" != installation_cocoapods_frameworks_swift ] || ./Tests/installation_tests/cocoapods/with_frameworks_swift/test.sh'
- '[ "$TEST_TYPE" != installation_manual ] || travis_retry ./Tests/installation_tests/manual_installation/test.sh'
- '[ "$TEST_TYPE" != installation_carthage ] || ./Tests/installation_tests/carthage/test.sh'
- '[ "$TEST_TYPE" != documentation ] || ./ci_scripts/check_documentation.sh'
6 changes: 6 additions & 0 deletions Stripe/PublicHeaders/STPAddress.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,10 @@ extern STPContactField const STPContactFieldName;
@return The closest representation of the billing address requirement as
a PKAddressField value.
*/
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should go before the documentation comment, build is failing because jazzy thinks these two methods are undocumented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fixed in da1cbea

+ (PKAddressField)applePayAddressFieldsFromBillingAddressFields:(STPBillingAddressFields)billingAddressFields;
#pragma clang diagnostic pop

/**
Converts a set of STPContactField values into the closest equivalent
Expand All @@ -230,7 +233,10 @@ extern STPContactField const STPContactFieldName;
@return The closest representation of the contact fields as
a PKAddressField value.
*/
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated"
+ (PKAddressField)pkAddressFieldsFromStripeContactFields:(nullable NSSet<STPContactField> *)contactFields;
#pragma clang diagnostic pop

/**
Converts a set of STPContactField values into the closest equivalent
Expand Down
7 changes: 0 additions & 7 deletions Tests/installation_tests/cocoapods/with_frameworks/Podfile
View file
Open in desktop

This file was deleted.

Loading