Fix PKAddress warnings #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danj-stripe
reviewed
Mar 20, 2018
| // | ||
|
|
||
| #import "ViewController.h" | ||
| #import <Stripe/Stripe.h> |
There was a problem hiding this comment.
I wasn't sure whether we wanted to use #import or @import - they both seemed to reproduce the warning. Is there a good reason to prefer one or the other here?
There was a problem hiding this comment.
I think they're effectively identical – #import maps to @import if modules are enabled, which is on by default in new projects.
Stripe/PublicHeaders/STPAddress.h
Outdated
| @@ -220,7 +220,10 @@ extern STPContactField const STPContactFieldName; | |||
| @return The closest representation of the billing address requirement as | |||
| a PKAddressField value. | |||
| */ | |||
| #pragma clang diagnostic push | |||
| #pragma clang diagnostic ignored "-Wdeprecated" | |||
There was a problem hiding this comment.
Looks like this should go before the documentation comment, build is failing because jazzy thinks these two methods are undocumented.
There was a problem hiding this comment.
👍 fixed in da1cbea
|
Fixes #912 |
csabol-stripe
pushed a commit
that referenced
this pull request
Mar 29, 2022
* Customize link inline sign up appearance * Styleize region placeholder * Change text color for legal view * Update from PR feedback * set font lastt * One more little hack * Call super and fix border color * update snapshots * update more snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @danj-stripe
Silences the deprecation warnings in STPAddress.h and adds a new objc installation test to catch regressions.
I also did some cleanup on the cocoapods installation projects:
_objc/_swift