Support slices in event.GetObjValue and add tests
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies `event.GetObjValue` so that when specifying additional keys to
descend into, it's now possible to specify integer keys if the target
object is a slice of type `[]interface{}` (which should be what anything
coming out of event data deserializes to).
I initially expressed some concern about expanding this interface, but
given that the previous behavior would have been an outright panic, I
changed my mind and don't think it's too bad to add support for this
given that it's been requested by a user.
Fixes #503.
ob-stripe
reviewed
Jan 8, 2018
event_test.go
Outdated
| // cases. | ||
| assert.Panicsf(t, func() { | ||
| event.GetObjValue("slice", "string_key") | ||
| }, "Cannot access nested slice element with non-integer key: %s", "bad_key") |
There was a problem hiding this comment.
I'm likely missing something since the tests are passing, but shouldn't the assert expect "string_key", not "bad_key"?
|
I left a question in a comment, but it's likely just me missing something. lgtm! (On an unrelated note, it looks like tests are failing on go-tip.) |
|
Thanks OB. I'm glad you noticed that testing problem — it turns out that what I really wanted was |
|
And good catch on go-tip. I think the patch in #508 will fix it. |
|
Released as 28.9.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
event.GetObjValueso that when specifying additional keys todescend into, it's now possible to specify integer keys if the target
object is a slice of type
[]interface{}(which should be what anythingcoming out of event data deserializes to).
I initially expressed some concern about expanding this interface, but
given that the previous behavior would have been an outright panic, I
changed my mind and don't think it's too bad to add support for this
given that it's been requested by a user.
Fixes #503.
r? @ob-stripe
cc @stripe/api-libraries