Stop validating api key (#506)

stripe · Jun 16, 2022 · 56c1c5a · 56c1c5a
1 parent 29080aa
commit 56c1c5a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app/controllers/api/configurations_controller.rb b/app/controllers/api/configurations_controller.rb
@@ -90,7 +90,7 @@ def post_install
         report_edge_case("updating api key for user, but is already set")
       end
 
-      if request.headers[SALESFORCE_INSTANCE_TYPE_HEADER].blank? || request.headers[SALESFORCE_PACKAGE_NAMESPACE_HEADER]
+      if request.headers[SALESFORCE_INSTANCE_TYPE_HEADER].blank? || request.headers[SALESFORCE_PACKAGE_NAMESPACE_HEADER].nil?
         report_edge_case("important headers are blank on post install")
       end
 
@@ -161,8 +161,9 @@ def update
 
       if @user.salesforce_organization_key != salesforce_api_key
         log.error 'api key does not match user'
-        head :not_found
-        return
+        # TODO until the issue with the package is resolved, this needs to stay the way it is
+        # head :not_found
+        # return
       end
 
       set_error_context(user: @user)

diff --git a/test/controllers/test_configurations_controller.rb b/test/controllers/test_configurations_controller.rb
@@ -156,6 +156,8 @@ class Critic::ConfigurationsControllerTest < ApplicationIntegrationTest
       # DB enforces that SF org IDs must be unique
 
       it 'throws an error if the api key does not match' do
+        skip("disabled until package is fixed and users are upgraded")
+
         get api_configuration_path, params: {}, headers: authentication_headers.merge(
           SALESFORCE_KEY_HEADER => SecureRandom.alphanumeric(16)
         )