Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin/Native runtime implementation #76

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

garyp
Copy link
Collaborator

@garyp garyp commented Aug 10, 2020

Originally based on cretz/pb-and-k#15. This is a
rebase of #29 onto the latest version of master.

Fixes #19.

Originally based on cretz/pb-and-k#15. This is a
rebase of #29 onto the latest version of master.

Fixes #19.
@garyp garyp merged commit 03be708 into master Aug 10, 2020
@garyp garyp deleted the garyp/kotlin-native branch August 10, 2020 17:04
@sebleclerc
Copy link
Contributor

@garyp Just curious, any reason using a second PR for the rebase and not using the rebase button inside the original PR ?

@garyp
Copy link
Collaborator Author

garyp commented Aug 10, 2020

@sebleclerc There were merge conflicts that couldn't be resolved automatically via the GitHub UI, so the rebase button in GitHub was disabled. I resolved them manually and sent you a PR to incorporate into your branch: Studyo#4. Since I didn't hear back from you on that PR I assumed you were busy. So I made a new PR with all of the changes. I made sure to keep the commit authorship info from your original PR to reflect the work that you did on it. Thank you again for your patience! I'm excited that we finally have K/N support in pbandk!

@sebleclerc
Copy link
Contributor

@garyp Sorry about that! Indeed I was on vacations for the last 3 weeks, but I do receive every GitHub notifications on my personal email and I don't recall seeing this 🤔 My bad, sorry about that!

And thanks to you for the work and help with K/N support! Eager to use it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin Native support
2 participants