Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master branch #4

Closed
wants to merge 5 commits into from
Closed

Conversation

garyp
Copy link

@garyp garyp commented Aug 5, 2020

This PR merges the master branch from streem/pbandk into your PR, resolving all conflicts. I can't merge your PR in GitHub right now because it has a conflict with the master branch. I'm not sure if there's a better way to handle this in GitHub, but I think if you merge this PR into your branch, then GitHub will let me squash & merge your PR into streem/pbandk.

tinder-aminghadersohi and others added 4 commits June 10, 2020 17:08
Use a chained `if-else` statement instead of chained `let` calls to avoid using stack memory for really large `oneof` objects.
This PR adds a new optional boolean parameter `json_support` to disable generating json marshal/unmarshal functionality. It is by default true hence the runtime and sample projects are not affected.

Fixes #54.
Fix protoc tasks to use a consistent version of the protoc binary
@garyp garyp force-pushed the garyp/kotlin-native branch 2 times, most recently from 7e6a94e to ed99bc2 Compare August 10, 2020 16:48
Originally based on cretz/pb-and-k#15. This is a
rebase of #29 onto the latest version of master.

Fixes #19.
@garyp
Copy link
Author

garyp commented Aug 10, 2020

I'm going to just do this via a new PR to streem/pbandk.

@garyp garyp closed this Aug 10, 2020
@garyp garyp deleted the garyp/kotlin-native branch August 10, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants