Don't log the whole client configurations for security

[BewareMyPower]

Motivation

pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/CachedPulsarClient.scala

Line 47 in 59066fc

logInfo(s"Client Conf = ${clientConf}")

The whole client configurations are logged, which might include the secret info whose key is authParams.

Modifications

Remove the logging for the whole client configuration. Actually, in PulsarConfigUpdater.rebuild, set will be called on each configuration, which is already logged here:

pulsar-spark/src/main/scala/org/apache/spark/sql/pulsar/PulsarConfigUpdater.scala

Lines 43 to 46 in 59066fc

	logInfo(
	s"$module: Set '$key' to " +
	s"'${printConfigValue(key, Option(value))}'," +
	s" earlier value: '${printConfigValue(key, pulsarParams.get(key))}'")

The printConfigValue method will hide the config of authParams, but it could still print 1/3 of the authParams, which could still leak some info, so just hide the whole authParams

Documentation

Check the box below.

Need to update docs?

• doc-required
• no-need-doc
• doc

[Anders-Frey]

Thanks for picking this up! I would like to add that the shortened print in the set function also reveals a fairly large chunk of the secret involved. Since the function cuts of the last third of the config value, a long value (like a JSON struct) could contain the sensitive information in the first two thirds of the value.

[BewareMyPower]

It makes sense. The whole authParams is hidden now.