Skip to content

Commit 87d447a

Browse files
Don't log the whole client configurations for security (#188)
1 parent 59066fc commit 87d447a

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

src/main/scala/org/apache/spark/sql/pulsar/CachedPulsarClient.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ private[pulsar] object CachedPulsarClient extends Logging {
4444
val clientConf =
4545
PulsarConfigUpdater("pulsarClientCache", config.asScala.toMap, PulsarOptions.FilteredKeys)
4646
.rebuild()
47-
logInfo(s"Client Conf = ${clientConf}")
4847

4948
val builder = PulsarClient.builder()
5049
try {

src/main/scala/org/apache/spark/sql/pulsar/PulsarConfigUpdater.scala

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,18 +76,12 @@ private[pulsar] case class PulsarConfigUpdater(
7676
map
7777
}
7878

79-
private val HideCompletelyLimit = 6
80-
private val ShowFractionOfHiddenValue = 1.0 / 3.0
8179
private val CompletelyHiddenMessage = "...<completely hidden>..."
8280

8381
private def printConfigValue(key: String, maybeVal: Option[Object]): String = {
8482
val value = maybeVal.map(_.toString).getOrElse("")
8583
if (keysToHideInLog.contains(key)) {
86-
if (value.length < HideCompletelyLimit) {
87-
return CompletelyHiddenMessage
88-
} else {
89-
return s"${value.take((value.length * ShowFractionOfHiddenValue).toInt)}..."
90-
}
84+
return CompletelyHiddenMessage
9185
}
9286

9387
value

0 commit comments

Comments
 (0)