[rahul05ranjan]

What's wrong

Offset Path remembers the values it was last confirmed with (#1152 — offset, joins, miterLimit are kept in app.ui.offset_path on OK), but the Preview checkbox is not among the kept fields. So every time the dialog opens — including for the next object — Preview starts unchecked (d.bool("preview") defaults to false when the field is absent), and it has to be ticked by hand every time (#3195).

Simplify's "Open this dialog with these settings next time" already keeps its preview field among SIMPLIFY_KEPT; Offset Path was the odd one out.

What the fix does

preview joins the fields Offset Path keeps on OK:

let kept = ["offset", "joins", "miterLimit", "preview"].into_iter()...

That is the whole change. Unchanged behaviour:

• A very first open (nothing confirmed yet) still starts unchecked.
• Cancel keeps nothing, as before.
• Turning Preview off before OK stores false, so an unchecked state is remembered too.

Verification

A regression test next to the existing offset_path_remembers_its_last_values (same harness, same shape):

#[test]
fn offset_path_remembers_its_last_preview_state() {
    // open, assert unchecked on a first open, tick Preview, confirm,
    // reopen, assert the checkbox is still on
}

I traced the flow on current main end to end (menus.rs:3390 opens on app.ui.offset_path when it is an object; form::preview_result writes the checkbox into d.fields["preview"]; Dialog::bool defaults to false), and the new test mirrors offset_path_remembers_its_last_values line by line — but I had no Rust toolchain on the machine I worked from, so I could not execute cargo test here. Flagging that plainly; happy to adjust if CI finds anything.

Fixes #3195

Summary by CodeRabbit

• Bug Fixes

  • The Offset Path dialog now preserves the Preview checkbox setting when reopened.

• Tests

  • Added coverage to verify the Preview setting is initially unchecked and remains enabled after being saved and reopened.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 549e685b-2a6e-4d6d-81b8-e689607c8912

📥 Commits

Reviewing files that changed from the base of the PR and between 9e7929e and c79e98f.

📒 Files selected for processing: 2

• crates/ui-egui/src/dialogs/path_ops.rs
• crates/ui-egui/src/dialogs/tests_modal.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The Offset Path dialog now retains the Preview checkbox state when reopened. A regression test verifies the unchecked default and confirms that an enabled state persists after confirmation and reopening.

Changes: Offset Path Preview State

Layer / File(s)	Summary
Save and test Preview state crates/ui-egui/src/dialogs/path_ops.rs, crates/ui-egui/src/dialogs/tests_modal.rs	The dialog retains the Preview checkbox state alongside the other Offset Path settings. The regression test checks the default unchecked state and verifies that an enabled state persists after reopening.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: bflatastic

Merge Risk: ⚪ Minimal · up to c79e9

The Preview preference now retains its confirmed state across dialog openings, including when switching objects, while first opens remain unchecked.

Architecture risk: 🔵 Low · up to c79e9

The change affects 1 system.

Changed systems: crates

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — crates (service) was modified; 2 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in crates/ui-egui/src/dialogs/path_ops.rs: Offset Path settings retained across dialog opens now include the preview checkbox state in addition to offset, join, and miter-limit values.
• observed — Modified behavior in crates/ui-egui/src/dialogs/tests_modal.rs: Added offset_path_remembers_its_last_preview_state, which checks the default unchecked state, confirms the dialog with preview enabled, then verifies the enabled state is restored on reopening.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly identifies the main change: preserving the Offset Path Preview checkbox state across dialog openings.
Description check		The description clearly explains the problem, the fix, expected behavior, linked issue, and regression test. It also states that cargo test was not run. The repository checklist is not included, but t…
Linked Issues check		Issue [#3195] requires Offset Path to remember the Preview state during the session, including later opens for another object. path_ops.rs now includes preview in the fields copied to `app.ui.offs…
Out of Scope Changes check		The changes are limited to the Offset Path retained-field list and one focused regression test in tests_modal.rs. Both changes directly support issue [#3195]. No unrelated product behavior or unrela…

Full details: Description check

Explanation

The description clearly explains the problem, the fix, expected behavior, linked issue, and regression test. It also states that cargo test was not run. The repository checklist is not included, but the description is otherwise mostly complete and relevant.

Full details: Linked Issues check

Explanation

Issue [#3195] requires Offset Path to remember the Preview state during the session, including later opens for another object. path_ops.rs now includes preview in the fields copied to app.ui.offset_path after confirmation. The existing dialog-open flow reads this shared state. The new offset_path_remembers_its_last_preview_state test verifies an initial unchecked state and persistence after confirmation. The implementation also stores false when that field is unchecked.

Full details: Out of Scope Changes check

Explanation

The changes are limited to the Offset Path retained-field list and one focused regression test in tests_modal.rs. Both changes directly support issue [#3195]. No unrelated product behavior or unrelated files are changed.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[Messhias]

cargo xtask ci is incomplete or unchecked on this PR. Run it end to end (fmt, clippy, tests, assets, brands, layers, wasm), tick the checklist when green, and reply here with the outcome. That is required before any approve from here.

[bflatastic]

Merged, thanks @rahul05ranjan! Offset Path's Preview checkbox keeps its last state across opens (#3195). If you'd like to talk about what's next, we're on Discord: https://discord.gg/artcraft