-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Automigration for upgrading storybook related dependencies #26377
CLI: Automigration for upgrading storybook related dependencies #26377
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b74ca12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…rading-storybook-related-deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Left some comments. Also a test for the new automigration would be nice ❤️
code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts
Show resolved
Hide resolved
code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts
Outdated
Show resolved
Hide resolved
code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts
Outdated
Show resolved
Hide resolved
code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts
Outdated
Show resolved
Hide resolved
code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts
Show resolved
Hide resolved
code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts
Outdated
Show resolved
Hide resolved
…ependencies.ts Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
Closes #25731
What I did
This automigration will only run if one of the following is true:
yarn sb automigrate upgradeStorybookRelatedDependencies
The auto migration performs the following:
storybook
in their name. This matches packages such as:eslint-plugin-storybook
@storybook/addon-designs
@chromatic-com/storybook
packageManager.latestVersion
for each entrypackage.json
file and then runpackageManager.installDependencies
dedupe
commandChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
I tested this by running it manually:
It's hard to simulate the code that triggers detecting if the user is updating to latest.
Here's what it looks like if it detects some packages being outdated:
And here's the full output, with the mini report and then the doctor output as well:
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>