remove hard-coded login in inner command

storybookjs · Mar 8, 2024 · 909cb23 · 909cb23
1 parent b4e944d
commit 909cb23
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts b/code/lib/cli/src/automigrate/fixes/upgrade-storybook-related-dependencies.ts
@@ -55,6 +55,12 @@ export const upgradeStorybookRelatedDependencies = {
   promptDefaultValue: false,
 
   async check({ packageManager, storybookVersion }) {
+    const latestStorybookVersion = await packageManager.latestVersion('storybook');
+
+    if (storybookVersion !== latestStorybookVersion) {
+      return null;
+    }
+
     const analyzedPackages = await getIncompatibleStorybookPackages({
       currentStorybookVersion: storybookVersion,
       packageManager,

diff --git a/code/lib/cli/src/automigrate/index.ts b/code/lib/cli/src/automigrate/index.ts
@@ -29,7 +29,6 @@ import { getMigrationSummary } from './helpers/getMigrationSummary';
 import { getStorybookData } from './helpers/mainConfigFile';
 import { doctor } from '../doctor';
 
-import { upgradeStorybookRelatedDependencies } from './fixes/upgrade-storybook-related-dependencies';
 import dedent from 'ts-dedent';
 
 const logger = console;
@@ -134,20 +133,7 @@ export const automigrate = async ({
     return null;
   }
 
-  const selectedFixes: Fix[] =
-    inputFixes ||
-    allFixes.filter((fix) => {
-      // we only allow this automigration when the user explicitly asks for it, or they are upgrading to the latest version of storybook
-      if (
-        fix.id === upgradeStorybookRelatedDependencies.id &&
-        isUpgrade !== 'latest' &&
-        fixId !== upgradeStorybookRelatedDependencies.id
-      ) {
-        return false;
-      }
-
-      return true;
-    });
+  const selectedFixes: Fix[] = inputFixes || allFixes;
   const fixes: Fix[] = fixId ? selectedFixes.filter((f) => f.id === fixId) : selectedFixes;
 
   if (fixId && fixes.length === 0) {