-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add community deploy for non kind clusters #86
add community deploy for non kind clusters #86
Conversation
@mikeshng I'm not understanding why this isn't using the existing |
@dhaiducek the current steps in https://open-cluster-management.io/getting-started/install-policy-controllers/#install-the-certificate-policy-controller uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I understand. And I've checked out your other PR on the OCM website to get a better view--I see you're creating targets to match app, which I like also for consistency.
I have a couple requested changes and then we can merge this in. Our squad can refactor it later to have the new target reference our existing deploy
target when we're completing a repo polish later.
Signed-off-by: Mike Ng <ming@redhat.com>
Kudos, SonarCloud Quality Gate passed! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, ycao56 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mike Ng ming@redhat.com
prereq to open-cluster-management-io/open-cluster-management-io.github.io#69