Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add community deploy for non kind clusters #86

Merged
merged 1 commit into from
May 3, 2021
Merged

add community deploy for non kind clusters #86

merged 1 commit into from
May 3, 2021

Conversation

mikeshng
Copy link
Contributor

@mikeshng mikeshng commented Apr 28, 2021

@dhaiducek
Copy link
Contributor

@mikeshng I'm not understanding why this isn't using the existing deploy Make target. Is this a common target you're planning to use OCM-wide? Otherwise, this new target is redundant since deploy is already configurable.

@mikeshng
Copy link
Contributor Author

@dhaiducek the current steps in https://open-cluster-management.io/getting-started/install-policy-controllers/#install-the-certificate-policy-controller uses make kind-deploy-controller which implies it only works for kind cluster. I want the target to be less kind specific but also don't want to break anything that uses the existing kind-deploy-controller target so I just blindly copied and paste and made the new community target. I didn't go thru the other targets so if you think deploy is good enough then deploy it is :) cheers.

Copy link
Contributor

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I understand. And I've checked out your other PR on the OCM website to get a better view--I see you're creating targets to match app, which I like also for consistency.

I have a couple requested changes and then we can merge this in. Our squad can refactor it later to have the new target reference our existing deploy target when we're completing a repo polish later.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Mike Ng <ming@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, ycao56

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5801967 into stolostron:main May 3, 2021
@mikeshng mikeshng deleted the add-community-deploy branch May 3, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants