update policy instructions to be compatible with non kind clusters #69
Conversation
Signed-off-by: Mike Ng <ming@redhat.com>
mikeshng
changed the title
| kind get kubeconfig --name <cluster name> --internal > $(PWD)/kubeconfig_hub | ||
| ``` | ||
|
|
||
| For non `kind` clusters: |
There was a problem hiding this comment.
I suggest to change non kind clusters to non-kind clusters
There was a problem hiding this comment.
thanks for catching that, done as suggested.
| @@ -55,20 +55,36 @@ Complete the following steps to install the policy framework from prebuild image | |||
| governance-policy-propagator-8c77f7f5f-kthvh 1/1 Running 0 94s | |||
| ``` | |||
|
|
|||
| 4. Deploy the policy framework components to the managed cluster. Run the following commands: | |||
| 4. Export the hub cluster kubeconfig with the following command: | |||
There was a problem hiding this comment.
I would monospace kubeconfig since it is in the command: kubeconfig
There was a problem hiding this comment.
thanks for catching that, done as suggested.
| kubectl config use-context <hub cluster context> # kubectl config use-context kind-hub | ||
|
|
||
| kubectl apply -n default -f https://raw.githubusercontent.com/open-cluster-management/policy-collection/main/stable/CM-Configuration-Management/policy-pod.yaml | ||
| $ kubectl config use-context <hub cluster context> # kubectl config use-context kind-hub |
There was a problem hiding this comment.
Is the dollar sign required? I always thought that was like a cursor in the terminal
There was a problem hiding this comment.
I always thought that was like a cursor in the terminal
I think the $ sign its just a Linux/Unix OS tradition to indicate its a terminal command. Since we are dealing with open source community, I think its more appropriate to use an open source OS convention. Thanks.
Is the dollar sign required?
In this case, I wanted the commands be distinguish from outputs that are results from the commands.
$ kubectl config use-context.... <--- command
$ kubectl apply -n default .... <--- command as well
policy.policy.open-cluster-management.io/policy-pod created <--- just outputs from the above command
placementbinding.policy.open-cluster-management.io/binding-policy-pod created <--- just outputs from the above command
placementrule.apps.open-cluster-management.io/placement-policy-pod created <--- just outputs from the above command
There was a problem hiding this comment.
@mikeshng understandable, thanks for explaining!
Signed-off-by: Mike Ng <ming@redhat.com>
|
new commit to fix the items that doc team found. 8ee7841 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dockerymick, mikeshng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mike Ng ming@redhat.com
has a dependencies on the following PRs:
stolostron/governance-policy-framework#100
stolostron/iam-policy-controller#52
stolostron/cert-policy-controller#86
stolostron/config-policy-controller#119