Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ioredis to v5.0.4 #1172

Merged
merged 9 commits into from
May 4, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: updated some integration tests
  • Loading branch information
Vamsi Ampolu committed May 4, 2022
commit 5e1843f2a87fa31f3615ff80120ad870c15fdb3c
2 changes: 1 addition & 1 deletion test/integration/commands/command.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ runTwinSuite('command', (command, equals) => {
expect(equals(sinter[0], 'sinter')).toBe(true)
expect(sinter[1]).toBe(-2)
expect(equals(sinter[2][0], 'readonly')).toBe(true)
expect(equals(sinter[2][1], 'sort_for_script')).toBe(true)
expect(equals(sinter[2][1], 'sort_for_script')).toBe(false)
expect(sinter[3]).toBe(1)
expect(sinter[4]).toBe(-1)
expect(sinter[5]).toBe(1)
Expand Down
4 changes: 2 additions & 2 deletions test/integration/commands/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ runTwinSuite('config', (command, equals) => {
try {
await redis[command]('foobar')
} catch (err) {
expect(err.message).toMatch('Unknown subcommand')
expect(err.message).toMatch('unknown subcommand')
}
})

Expand Down Expand Up @@ -71,7 +71,7 @@ runTwinSuite('config', (command, equals) => {
await redis[command]('SET', 'maxmockmemory', '1000000')
} catch (err) {
expect(err.message).toMatch(
'ERR Unsupported CONFIG parameter: maxmockmemory'
"ERR Unknown option or number of arguments for CONFIG SET - 'maxmockmemory'"
)
}
})
Expand Down
12 changes: 4 additions & 8 deletions test/integration/commands/object.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,8 @@ runTwinSuite('object', command => {

it('should throw on too few arguments', async () => {
expect.hasAssertions()

try {
await redis[command]()
} catch (err) {
expect(err.message).toMatch('wrong number of arguments')
}
await expect(() => redis[command]()).rejects.toThrow('wrong number of arguments');

})

it('should throw on unknown subcommand', async () => {
Expand All @@ -27,7 +23,7 @@ runTwinSuite('object', command => {
try {
await redis[command]('foobar')
} catch (err) {
expect(err.message).toMatch('Unknown subcommand')
expect(err.message).toMatch('unknown subcommand')
}
})

Expand Down Expand Up @@ -91,7 +87,7 @@ runTwinSuite('object', command => {
const mysortedset = await redis[command]('encoding', 'mysortedset')
expect(
Buffer.isBuffer(mysortedset) ? mysortedset.toString() : mysortedset
).toBe('ziplist')
).toBe('listpick')
})
})

Expand Down