Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ioredis to v5.0.4 #1172

Merged
merged 9 commits into from
May 4, 2022
Merged

Conversation

vamsiampolu
Copy link
Contributor

Changes

  • update ioredis in peerDependencies to 5.x and devDependencies to 5.0.4.
  • use ioredis/built/Command instead of ioredis/built/command to fix tests.
  • remove PromiseContainer and any references to it.

@vamsiampolu vamsiampolu changed the title Allow ioredis-mock to be used with ioredis@5.0.4 chore(deps): update ioredis to v5.0.4 Apr 22, 2022
@vamsiampolu vamsiampolu reopened this Apr 22, 2022
@crobinson42
Copy link

This would be great to get merged and published 🙏

@crobinson42
Copy link

@stipsan Can I help get a release moved along here? I think this PR is a better solution for ioredis@5 vs #1163 since this removes the promise lib that ioredis no longer supports.

@stipsan
Copy link
Owner

stipsan commented May 3, 2022

Hi @vamsiampolu and @crobinson42 😄
I would love to clean house and get rid of that old dusty Promise lib thingy, sure!
All I need is a new section under Breaking Changes and let's get this PR merged 😌

Copy link
Owner

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I merged #1166 first as it didn't require any changes to the README to land.
Everything else in the PR looks good 👍

@vamsiampolu
Copy link
Contributor Author

Is there something I can do to help with remote: Permission to vamsiampolu/ioredis-mock.git denied to github-actions[bot].

@stipsan
Copy link
Owner

stipsan commented May 4, 2022

Is there something I can do to help with remote: Permission to vamsiampolu/ioredis-mock.git denied to github-actions[bot].

No, that task isn't supposed to run on forks and I've tried to make it only run on upstream multiple times but it's stubborn D:

Thanks for the bonus fixes you pushed to the e2e suite btw ❤️ I'll merge this and fix the build errors on main!

@stipsan stipsan merged commit e0ff66f into stipsan:main May 4, 2022
@stipsan
Copy link
Owner

stipsan commented May 4, 2022

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants