Fix dev container and Cloudfront version check (#542)

* Fix docker dev container build * Fix boolean on Cloudfront MinimumProtocolVersionRule
stelligent · Apr 2, 2021 · 633e5d0 · 633e5d0
1 parent a9c403a
commit 633e5d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.devcontainer/build/Dockerfile b/.devcontainer/build/Dockerfile
@@ -58,7 +58,7 @@ RUN echo 'export GPG_TTY="$(tty)"' >> /home/$USERNAME/.bashrc \
   && chown -R $USERNAME /home/$USERNAME/.gnupg
 
 # Add non-root user to gems and bundle
-RUN chown -R $USERNAME /usr/local/lib/ruby/gems/2.5.0 \
+RUN chown -R $USERNAME /usr/local/lib/ruby/gems/2.7.0 \
   && chown -R $USERNAME /usr/local/bundle
 
 # Enter container as non-root user

diff --git a/lib/cfn-nag/custom_rules/CloudfrontMinimumProtocolVersionRule.rb b/lib/cfn-nag/custom_rules/CloudfrontMinimumProtocolVersionRule.rb
@@ -33,7 +33,7 @@ def tls_version?(viewer_certificate)
 
   def cert_has_bad_tls_version?(min_protocol_version)
     min_protocol_version.nil? ||
-      (min_protocol_version.is_a?(String) && min_protocol_version.start_with?('TLSv1.2'))
+      (min_protocol_version.is_a?(String) && !min_protocol_version.start_with?('TLSv1.2'))
   end
 
   def override_tls_config?(viewer_certificate)