Fix end-to-end test with Cloudfront MinimumProtocolVersion (#541)

stelligent · Apr 2, 2021 · a9c403a · a9c403a
1 parent a5b43be
commit a9c403a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/cfn-nag/custom_rules/CloudfrontMinimumProtocolVersionRule.rb b/lib/cfn-nag/custom_rules/CloudfrontMinimumProtocolVersionRule.rb
@@ -28,12 +28,12 @@ def audit_impl(cfn_model)
   private
 
   def tls_version?(viewer_certificate)
-    cert_has_bad_tls_version?(viewer_certificate) || override_tls_config?(viewer_certificate)
+    cert_has_bad_tls_version?(viewer_certificate['MinimumProtocolVersion']) || override_tls_config?(viewer_certificate)
   end
 
-  def cert_has_bad_tls_version?(viewer_certificate)
-    viewer_certificate['MinimumProtocolVersion'].nil? ||
-      !viewer_certificate['MinimumProtocolVersion'].start_with?('TLSv1.2')
+  def cert_has_bad_tls_version?(min_protocol_version)
+    min_protocol_version.nil? ||
+      (min_protocol_version.is_a?(String) && min_protocol_version.start_with?('TLSv1.2'))
   end
 
   def override_tls_config?(viewer_certificate)