Skip to content

p25 cap cleanup #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomerweller wants to merge 2 commits into from
Closed

p25 cap cleanup #1874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6fbda1
p25 cap cleanup
tomerweller Feb 3, 2026
8cebdc1
Update CAP-0074 and CAP-0075 to protocol version 25 and Final status …
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,10 @@
| [CAP-0068](cap-0068.md) | 23 | Host function for getting executable for `Address` | Dmytro Kozhevin | Final |
| [CAP-0069](cap-0069.md) | 23 | String/Bytes conversion host functions | Dmytro Kozhevin | Final |
| [CAP-0070](cap-0070.md) | 23 | Configurable SCP Timing Parameters | Garand Tyson | Final |
| [CAP-0074](cap-0074.md) | Host functions for BN254 | Siddharth Suresh | Awaiting Decision |
| [CAP-0075](cap-0075.md) | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision |
| [CAP-0076](cap-0076.md) | P23 State Archival bug remediation | Dmytro Kozhevin | Final |
| [CAP-0076](cap-0076.md) | 24 | P23 State Archival bug remediation | Dmytro Kozhevin | Final |
| [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final |
| [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final |
Comment on lines +86 to +87
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README marks CAP-0074 and CAP-0075 as Protocol Version = 25 and Status = Final, but the CAP documents themselves currently say Protocol version: 24 and Status: Awaiting Decision in their preambles (see core/cap-0074.md:10-14 and core/cap-0075.md:10-14). Please update the CAP preambles to match this table, or adjust these table entries to reflect the current CAP metadata so the index stays consistent.

Suggested change
| [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final |
| [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final |
| [CAP-0074](cap-0074.md) | 24 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision |
| [CAP-0075](cap-0075.md) | 24 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision |

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@tomerweller tomerweller Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you change the cap documents themselves to say protocol version 25 and final?

Comment on lines +85 to +87
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list appears to be ordered by CAP number throughout the table, but CAP-0076 is now listed before CAP-0074 and CAP-0075. Consider reordering these rows back to numeric order (0074, 0075, 0076) to keep the index consistent and easier to scan.

Suggested change
| [CAP-0076](cap-0076.md) | 24 | P23 State Archival bug remediation | Dmytro Kozhevin | Final |
| [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final |
| [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final |
| [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final |
| [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final |
| [CAP-0076](cap-0076.md) | 24 | P23 State Archival bug remediation | Dmytro Kozhevin | Final |

Copilot uses AI. Check for mistakes.


### Draft Proposals
| Number | Title | Author | Status |
Expand Down
4 changes: 2 additions & 2 deletions core/cap-0074.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ Working Group:
Owner: Siddharth Suresh <@sisuresh>
Authors: Siddharth Suresh <@sisuresh>, Jay Geng <@jayz22>, Matteo Lisotto
Consulted: Jay Geng <@jayz22>, Anup Pani <@anupsdf>
Status: Awaiting Decision
Status: Final
Created: 2025-09-25
Discussion: https://github.com/orgs/stellar/discussions/1772
Protocol version: 24
Protocol version: 25
```

## Simple Summary
Expand Down
4 changes: 2 additions & 2 deletions core/cap-0075.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ Working Group:
Owner: Jay Geng <@jayz22>
Authors: Jay Geng <@jayz22>
Consulted: Antonio <@Fantoni0>, Yan <@ymcrcat>, Tomer Weller <@tomerweller>
Status: Awaiting Decision
Status: Final
Created: 2025-10-08
Discussion: TBD
Protocol version: 24
Protocol version: 25
```

## Simple Summary
Expand Down
Loading