p25 cap cleanup #1874
p25 cap cleanup #1874
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CAP index table in core/README.md as part of protocol-25 cleanup by adjusting protocol-version/status metadata for recent CAP entries.
Changes:
- Adds protocol version
24to CAP-0076 and moves it in the list. - Updates CAP-0074 and CAP-0075 entries to protocol version
25and statusFinal. - Removes the “Awaiting Decision” rows for CAP-0074/0075 in favor of the updated entries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final | | ||
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final | |
There was a problem hiding this comment.
The README marks CAP-0074 and CAP-0075 as Protocol Version = 25 and Status = Final, but the CAP documents themselves currently say Protocol version: 24 and Status: Awaiting Decision in their preambles (see core/cap-0074.md:10-14 and core/cap-0075.md:10-14). Please update the CAP preambles to match this table, or adjust these table entries to reflect the current CAP metadata so the index stays consistent.
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final | | |
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final | | |
| | [CAP-0074](cap-0074.md) | 24 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | |
| | [CAP-0075](cap-0075.md) | 24 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | |
There was a problem hiding this comment.
@copilot can you change the cap documents themselves to say protocol version 25 and final?
| | [CAP-0076](cap-0076.md) | 24 | P23 State Archival bug remediation | Dmytro Kozhevin | Final | | ||
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final | | ||
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final | |
There was a problem hiding this comment.
This list appears to be ordered by CAP number throughout the table, but CAP-0076 is now listed before CAP-0074 and CAP-0075. Consider reordering these rows back to numeric order (0074, 0075, 0076) to keep the index consistent and easier to scan.
| | [CAP-0076](cap-0076.md) | 24 | P23 State Archival bug remediation | Dmytro Kozhevin | Final | | |
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final | | |
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final | | |
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Final | | |
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Final | | |
| | [CAP-0076](cap-0076.md) | 24 | P23 State Archival bug remediation | Dmytro Kozhevin | Final | |
|
@tomerweller I've opened a new pull request, #1875, to work on those changes. Once the pull request is ready, I'll request review from you. |
…1875) * Initial plan * Update CAP-0074 and CAP-0075 to protocol version 25 and Final status Co-authored-by: tomerweller <815704+tomerweller@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tomerweller <815704+tomerweller@users.noreply.github.com>
|
closing in favor of letting the machine do it |
No description provided.