Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDP-1121]: Improve frontend message when the distribution account doesn't exist #80

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

ceciliaromao
Copy link
Contributor

The message is not helpful and you cannot read the whole public key, so it’s impossible to move on from here, unless you have access to the values from the DB.
That happens in the “Distribution Account” screen.

Error message fixed to show entire public key.

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr80.previews.kube001.services.stellar-ops.com/

@ceciliaromao ceciliaromao merged commit 721f729 into develop Mar 13, 2024
5 checks passed
@ceciliaromao ceciliaromao deleted the sdp-1121_improve-error-message branch March 13, 2024 19:52
Copy link
Collaborator

@marwen-abid marwen-abid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marcelosalloum added a commit that referenced this pull request Apr 15, 2024
## [1.1.2](stellar/stellar-disbursement-platform-backend@1.1.1...1.1.2)

Attention, this version is compatible with the backend version
[1.1.6](https://github.com/stellar/stellar-disbursement-platform-backend/releases/tag/1.1.6).

### Added

- Add the "Future Balance" label in the disbursement detail component to display
  what will be balance for the asset on the distribution account after the
  disbursement is completed.
  [#76](#76)
- Add option to update a receiver's verification info from the receiver's detail
  page.
  [#78](#78)

### Changed

- Update the CSV template by adding examples with and without the paymentID
  (optional) column.
  [#77](#77)
- Display the entire disbursement account address for the tenant when that
  disbursement account does not exist in the network, making it easier to
  identify the account that needs to be funded.
  [#80](#80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants