Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDP-1068] Display future balance #76

Merged
merged 11 commits into from
Feb 23, 2024
Merged

[SDP-1068] Display future balance #76

merged 11 commits into from
Feb 23, 2024

Conversation

CaioTeixeira95
Copy link
Contributor

This PR adds the Future Balance label in the DisbursementDetails component to display the balance for the asset on the distribution account after the disbursement is completed.

@CaioTeixeira95 CaioTeixeira95 self-assigned this Feb 16, 2024
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr76.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr76.previews.kube001.services.stellar-ops.com/

quietbits
quietbits reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@quietbits quietbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌 I just have a few small comments/suggestions.

❓ Should we use BigNumber for futureBalance calculations? If we're dealing with precision greater than 2 decimal points, we could run into some issues with the "normal" calculations. Thoughts? 🙏

src/components/DisbursementDetails/index.tsx Outdated Show resolved Hide resolved
src/components/DisbursementDetails/index.tsx Outdated Show resolved Hide resolved
src/pages/DisbursementDraftDetails.tsx Outdated Show resolved Hide resolved
src/pages/DisbursementDraftDetails.tsx Outdated Show resolved Hide resolved
src/pages/DisbursementsNew.tsx Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr76.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr76.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr76.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr76.previews.kube001.services.stellar-ops.com/

quietbits
quietbits approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@quietbits quietbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Just a nitpick about the order of imports. We try to group them like this: libraries > absolute paths > types > styles

For example:
image

@CaioTeixeira95
lint: fix import order
1cd28e0
@CaioTeixeira95
Merge branch 'sdp-1068_display-future-balance' of github.com:stellar/…
56017e5 
…stellar-disbursement-platform-frontend into sdp-1068_display-future-balance
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr76.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr76.previews.kube001.services.stellar-ops.com/

@CaioTeixeira95 CaioTeixeira95 merged commit a962e20 into develop Feb 23, 2024
5 checks passed
@CaioTeixeira95 CaioTeixeira95 deleted the sdp-1068_display-future-balance branch February 23, 2024 20:12
marcelosalloum added a commit that referenced this pull request Apr 15, 2024
@marcelosalloum
Merge pull request #91: release/1.1.2 to main
5248c97 
## [1.1.2](stellar/stellar-disbursement-platform-backend@1.1.1...1.1.2)

Attention, this version is compatible with the backend version
[1.1.6](https://github.com/stellar/stellar-disbursement-platform-backend/releases/tag/1.1.6).

### Added

- Add the "Future Balance" label in the disbursement detail component to display
  what will be balance for the asset on the distribution account after the
  disbursement is completed.
  [#76](#76)
- Add option to update a receiver's verification info from the receiver's detail
  page.
  [#78](#78)

### Changed

- Update the CSV template by adding examples with and without the paymentID
  (optional) column.
  [#77](#77)
- Display the entire disbursement account address for the tenant when that
  disbursement account does not exist in the network, making it easier to
  identify the account that needs to be funded.
  [#80](#80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quietbits quietbits quietbits approved these changes

@marcelosalloum marcelosalloum Awaiting requested review from marcelosalloum

@marwen-abid marwen-abid Awaiting requested review from marwen-abid

@ceciliaromao ceciliaromao Awaiting requested review from ceciliaromao

@ziyliu ziyliu Awaiting requested review from ziyliu

Assignees

@CaioTeixeira95 CaioTeixeira95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaioTeixeira95 @stellar-jenkins @quietbits @ceciliaromao