-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Bump go version and make other project maintenance changes #196
Conversation
stellar-disbursement-platform-backend-preview is available here: |
stellar-disbursement-platform-backend-preview is available here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
exit 1 | ||
else | ||
echo "✅ No deadcode found" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go 🚀
[Merge] Merge `develop` into `sdp-multitenant` ```text Conflicts: .github/workflows/ci.yml cmd/serve_test.go go.sum internal/data/disbursement_instructions.go internal/data/disbursement_instructions_test.go internal/serve/httphandler/assets_handler_test.go internal/serve/serve.go internal/serve/serve_test.go ``` Merged PRs: - #178 - #185 - #195 - #181 - #196
## [1.1.6](1.1.5...1.1.6) Attention, this version is compatible with the frontend version [1.1.2](https://github.com/stellar/stellar-disbursement-platform-frontend/releases/tag/1.1.2). ### Changed - Update the `PATCH /receivers/{id}` request, so a receiver's verification info is not just inserted but upserted. The update part of the upsert only takes place if the verification info has not been confirmed yet. [#205](#205) - Update the order of the verification field that is shown to the receiver during the [SEP-24] flow. The order was `(updated_at DESC)` and was updated to the composed sorting `(updated_at DESC, rv.verification_field ASC)` to ensure consistency when multiple verification fields share the same `updated_at` value. - Improve information in the error message returned when the disbursement instruction contains a verification info that is different from an already existing verification info that was already confirmed by the receiver. [#178](#178) - When adding an asset, make sure to trim the spaces fom the issuer field. [#185](#185) ### Security - Bump Go version from 1.19 to 1.22, and upgraded the version of some CI tools. [#196](#196) - Add rate-limiter in both in the application and the kubernetes deployment. [#195](#195)
What
slices
dependency to use the one that's now part of the Go SDK.deadcode
to the CI, to make sure there's no unused code in the project.Why
We were falling behind on the version upgrade.
The other bullets are also project maintenance.
Checklist
PR Structure
Thoroughness
Configs and Secrets
values.yaml
file.pr-preview
,dev
,demo
,prd
).values.yaml
file.pr-preview secrets
,dev secrets
,demo secrets
,prd secrets
).Release
develop
ormain
after it's ready for production!Deployment