Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Bump go version and make other project maintenance changes #196

Merged
merged 10 commits into from
Feb 21, 2024

Conversation

marcelosalloum
Copy link
Collaborator

@marcelosalloum marcelosalloum commented Feb 16, 2024

What

  • Bump go version from 1.19 (released 2022-08-02) to 1.22 (released 2024-02-06).
  • Updated the version of some github actions
  • Updated slices dependency to use the one that's now part of the Go SDK.
  • Removed two unused methods
  • Apply deadcode to the CI, to make sure there's no unused code in the project.

Why

We were falling behind on the version upgrade.

The other bullets are also project maintenance.

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests February 16, 2024 23:09 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests February 16, 2024 23:09 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum changed the title [Chore] Bump go version [Chore] Bump go version and other project maintenance changes Feb 16, 2024
@marcelosalloum marcelosalloum temporarily deployed to Anchor Integration Tests February 16, 2024 23:12 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests February 16, 2024 23:12 — with GitHub Actions Inactive
@marcelosalloum marcelosalloum marked this pull request as ready for review February 16, 2024 23:16
@marcelosalloum marcelosalloum requested a review from a team February 16, 2024 23:16
@marcelosalloum marcelosalloum self-assigned this Feb 17, 2024
Copy link
Collaborator

@marwen-abid marwen-abid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

exit 1
else
echo "✅ No deadcode found"
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition!

Copy link
Contributor

@CaioTeixeira95 CaioTeixeira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@marcelosalloum marcelosalloum changed the title [Chore] Bump go version and other project maintenance changes [Chore] Bump go version and make other project maintenance changes Feb 20, 2024
@marcelosalloum marcelosalloum merged commit a179582 into develop Feb 21, 2024
10 checks passed
@marcelosalloum marcelosalloum deleted the marcelo/chore-bump-go-version branch February 21, 2024 16:59
marcelosalloum added a commit that referenced this pull request Feb 21, 2024
[Merge] Merge `develop` into `sdp-multitenant`

```text
Conflicts:
	.github/workflows/ci.yml
	cmd/serve_test.go
	go.sum
	internal/data/disbursement_instructions.go
	internal/data/disbursement_instructions_test.go
	internal/serve/httphandler/assets_handler_test.go
	internal/serve/serve.go
	internal/serve/serve_test.go
```

Merged PRs:

- #178
- #185
- #195
- #181
- #196
marcelosalloum added a commit that referenced this pull request Apr 15, 2024
## [1.1.6](1.1.5...1.1.6)

Attention, this version is compatible with the frontend version [1.1.2](https://github.com/stellar/stellar-disbursement-platform-frontend/releases/tag/1.1.2).

### Changed

- Update the `PATCH /receivers/{id}` request, so a receiver's verification info is not just inserted but upserted. The update part of the upsert only takes place if the verification info has not been confirmed yet. [#205](#205)
- Update the order of the verification field that is shown to the receiver during the [SEP-24] flow. The order was `(updated_at DESC)` and was updated to the composed sorting `(updated_at DESC, rv.verification_field ASC)` to ensure consistency when multiple verification fields share the same `updated_at` value.
- Improve information in the error message returned when the disbursement instruction contains a verification info that is different from an already existing verification info that was already confirmed by the receiver. [#178](#178)
- When adding an asset, make sure to trim the spaces fom the issuer field. [#185](#185)

### Security

- Bump Go version from 1.19 to 1.22, and upgraded the version of some CI tools. [#196](#196)
- Add rate-limiter in both in the application and the kubernetes deployment. [#195](#195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants