SDP-575: [data] Improve receiver verification error messaging for disbursement instructions #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaromao
temporarily deployed
to
Receiver Registration - E2E Integration Tests
GitHub Actions
Inactive
ceciliaromao
temporarily deployed
to
Anchor Integration Tests
GitHub Actions
Inactive
This comment was marked as outdated.
This comment was marked as outdated.
ceciliaromao
temporarily deployed
to
Receiver Registration - E2E Integration Tests
GitHub Actions
Inactive
ceciliaromao
temporarily deployed
to
Anchor Integration Tests
GitHub Actions
Inactive
This comment was marked as outdated.
This comment was marked as outdated.
ceciliaromao
temporarily deployed
to
Receiver Registration - E2E Integration Tests
GitHub Actions
Inactive
ceciliaromao
temporarily deployed
to
Anchor Integration Tests
GitHub Actions
Inactive
|
stellar-disbursement-platform-backend-preview is available here: |
ceciliaromao
requested review from
marcelosalloum,
marwen-abid,
ziyliu and
CaioTeixeira95
CaioTeixeira95
approved these changes
Feb 9, 2024
ceciliaromao
temporarily deployed
to
Anchor Integration Tests
GitHub Actions
Inactive
ceciliaromao
temporarily deployed
to
Receiver Registration - E2E Integration Tests
GitHub Actions
Inactive
|
stellar-disbursement-platform-backend-preview is available here: |
ceciliaromao
deleted the
sdp-575_receiver-verification-error-messaging
branch
marcelosalloum
added a commit
that referenced
this pull request
Feb 21, 2024
[Merge] Merge `develop` into `sdp-multitenant` ```text Conflicts: .github/workflows/ci.yml cmd/serve_test.go go.sum internal/data/disbursement_instructions.go internal/data/disbursement_instructions_test.go internal/serve/httphandler/assets_handler_test.go internal/serve/serve.go internal/serve/serve_test.go ``` Merged PRs: - #178 - #185 - #195 - #181 - #196
marcelosalloum
added a commit
that referenced
this pull request
Apr 15, 2024
## [1.1.6](1.1.5...1.1.6) Attention, this version is compatible with the frontend version [1.1.2](https://github.com/stellar/stellar-disbursement-platform-frontend/releases/tag/1.1.2). ### Changed - Update the `PATCH /receivers/{id}` request, so a receiver's verification info is not just inserted but upserted. The update part of the upsert only takes place if the verification info has not been confirmed yet. [#205](#205) - Update the order of the verification field that is shown to the receiver during the [SEP-24] flow. The order was `(updated_at DESC)` and was updated to the composed sorting `(updated_at DESC, rv.verification_field ASC)` to ensure consistency when multiple verification fields share the same `updated_at` value. - Improve information in the error message returned when the disbursement instruction contains a verification info that is different from an already existing verification info that was already confirmed by the receiver. [#178](#178) - When adding an asset, make sure to trim the spaces fom the issuer field. [#185](#185) ### Security - Bump Go version from 1.19 to 1.22, and upgraded the version of some CI tools. [#196](#196) - Add rate-limiter in both in the application and the kubernetes deployment. [#195](#195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Clear error message about which receiver (line in CSV & phone number / internal id) that has a mis-matching verification.
Why
If the user doesn't know which record is causing the error, they won't know where to check to find the original value.
Known limitations
N/A
Checklist
PR Structure
Thoroughness
Configs and Secrets
values.yamlfile.pr-preview,dev,demo,prd).values.yamlfile.pr-preview secrets,dev secrets,demo secrets,prd secrets).Release
developormainafter it's ready for production!Deployment