Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulate maximum possible nonce expiration in recording auth mode. #1419

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Emulate maximum possible nonce expiration in recording auth mode. #1419

merged 3 commits into from
Jun 6, 2024

Commits on Jun 5, 2024

  1. Emulate maximum possible nonce expiration in recording auth mode. 

    Currently we don't really know what's the intended signature expiration during the auth simulation. Since there is always a potential option for the user to want to customize their signature expiration at the time of signing the auth (even though that option might not currently exist in the wallets), there is really no way to do better than assuming maximum possible expiration and thus maximum possible rent fee. Since the rent fee is refundable, the end user impact is just a slightly higher fee locked before applying the transaction and refunding the unused rent fee portion.
    @dmkozh
    dmkozh committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    259dd86 View commit details
    Browse the repository at this point in the history

  2. Update observations. 

    The only change is storage for the storage hash after require_auth, which is expected because this test is using `require_auth` (which in turn now modifies the storage contents).
    @dmkozh
    dmkozh committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e1281d7 View commit details
    Browse the repository at this point in the history

  3. !fixup update v20 simulation test data

    @dmkozh
    dmkozh committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8d4b541 View commit details
    Browse the repository at this point in the history