Emulate maximum possible nonce expiration in recording auth mode. #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we don't really know what's the intended signature expiration during the auth simulation. Since there is always a potential option for the user to want to customize their signature expiration at the time of signing the auth (even though that option might not currently exist in the wallets), there is really no way to do better than assuming maximum possible expiration and thus maximum possible rent fee. Since the rent fee is refundable, the end user impact is just a slightly higher fee locked before applying the transaction and refunding the unused rent fee portion.
leighmcculloch
approved these changes
Jun 5, 2024
The only change is storage for the storage hash after require_auth, which is expected because this test is using `require_auth` (which in turn now modifies the storage contents).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Emulate maximum possible nonce expiration in recording auth mode.
Why
Currently we don't really know what's the intended signature expiration during the auth simulation. Since there is always a potential option for the user to want to customize their signature expiration at the time of signing the auth (even though that option might not currently exist in the wallets), there is really no way to do better than assuming maximum possible expiration and thus maximum possible rent fee. Since the rent fee is refundable, the end user impact is just a slightly higher fee locked before applying the transaction and refunding the unused rent fee portion.
Known limitations
N/A