Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in soroban-simulation #1361

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Commits on Mar 1, 2024

  1. Small fixes in soroban-simulation:

    - Use `&impl SnapshotSourceWithArchive` in `load_from_snapshot`. This is not very pretty semantically, but there is no clean way for storage to implement archived entry filtering without accessing the config and I really want to encapsulate the config-related logic in `NetworkConfig` struct. The alternative would be for `SnapshotSource` implementer to either load the state expiration config before building the config, or to not follow the interface contract of `SnapshotSource` to not ever return expired entries.
    - Use `&self` in `fill_config_fields_in_ledger_info`
    dmkozh committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    be7432d View commit details
    Browse the repository at this point in the history