Small fixes in soroban-simulation #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `&impl SnapshotSourceWithArchive` in `load_from_snapshot`. This is not very pretty semantically, but there is no clean way for storage to implement archived entry filtering without accessing the config and I really want to encapsulate the config-related logic in `NetworkConfig` struct. The alternative would be for `SnapshotSource` implementer to either load the state expiration config before building the config, or to not follow the interface contract of `SnapshotSource` to not ever return expired entries. - Use `&self` in `fill_config_fields_in_ledger_info`
sisuresh
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
&impl SnapshotSourceWithArchiveinload_from_snapshot. This is not very pretty semantically, but there is no clean way for storage to implement archived entry filtering without accessing the config and I really want to encapsulate the config-related logic inNetworkConfigstruct. The alternative would be forSnapshotSourceimplementer to either load the state expiration config before building the config, or to not follow the interface contract ofSnapshotSourceto not ever return expired entries.&selfinfill_config_fields_in_ledger_infoWhy
Issue fixes
Known limitations
N/A