Merge Protocol 19 features into master.
#521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update .x and generated code to latest XDR * Update code for Protocol 19 XDR: - transactions have .cond() instead of .timeBounds() - timebounds need to be accessed diff. for v0 and v1 txs - type rename for OperationId -> HashIdPreimage, etc. * Update generated Typescript to lint properly
* Bump minimum Node version to 14.x. (#510) * Bump CI scripts, NVM version, and README to minimum Node 14 * Stop failing fast in GHA to identify version-specific failures * Drop tests for 17.x because of incompatibility: Node 17.x upgrades OpenSSL to v3 which basically changes some stuff related to hashing in a way that isn't backwards compatible. Relevant link: webpack/webpack#14532 (comment) This (a) causes breakages that aren't relevant to us and (b) has a dangerous workaround: export NODE_OPTIONS=--openssl-legacy-provider If we do this workaround here, we are basically brushing the issue under the rug. The longer term solution is basically to let the ecosystem deal with it for now and when we need to make 18.x the minimum, to deal with it in turn. Since our minimum is 14.x for now, there's no reason to do 17.x-specific upgrades or workarounds. * Bump minimist from 1.2.5 to 1.2.6 (#514) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump karma from 6.3.4 to 6.3.16 (#505) Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v6.3.4...v6.3.16) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ajv from 6.12.2 to 6.12.6 (#503) * Upgrades various developer dependencies (#500) * Upgrade 'isparta' to the latest version * Upgrade 'jsdoc' to latest version * Unpin 'underscore' in order to upgrade minor version * Let all Node jobs run * Add CHANGELOG entry for @dependabot shenanigans (#519) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: George Kudrayvtsev <george@stellar.org>
paulbellamy
approved these changes
Apr 7, 2022
|
|
||
| - Support for creating transactions with the new preconditions ([CAP-21](https://stellar.org/protocol/cap-21)) via `TransactionBuilder` ([#513](https://github.com/stellar/js-stellar-base/pull/513)). | ||
|
|
||
| - A way to convert between addresses (like `G...` and `P...`, i.e. the `StrKey` class) and their respective signer keys (i.e. `xdr.SignerKey`s), particularly for use in the new transaction preconditions ([#520](https://github.com/stellar/js-stellar-base/pull/520)). |
There was a problem hiding this comment.
There's probably a few more things we've added here? like api support for protocol 19, etc.
There was a problem hiding this comment.
API support is part of stellar/js-stellar-sdk; I don't want to conflate what changed where
overcat
reviewed
Apr 10, 2022
overcat
reviewed
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.