Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstraction to convert between xdr.SignerKeys and signers (strkeys) #520

Merged
merged 8 commits into from
Apr 6, 2022

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Apr 5, 2022

No description provided.

@Shaptic Shaptic requested a review from paulbellamy April 5, 2022 19:47
@Shaptic Shaptic self-assigned this Apr 5, 2022
Copy link
Contributor

@paulbellamy paulbellamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and suggestions, but lgtm.

test/unit/signerkey_test.js Show resolved Hide resolved
src/signerkey.js Show resolved Hide resolved
src/signerkey.js Show resolved Hide resolved
src/signerkey.js Show resolved Hide resolved
@Shaptic Shaptic merged commit 852925d into protocol-19 Apr 6, 2022
@Shaptic Shaptic deleted the strkey-n-signers branch April 6, 2022 17:30
Shaptic added a commit that referenced this pull request Apr 11, 2022
* Update XDR definitions and relevant code for Protocol 19 (#509)
* Add support for signed payload signer keys to `StrKey` (#511)
* Support new preconditions when using building transactions (#513)
* Add conversion layer between `xdr.SignerKey`s and `StrKey`s (#520, #523)

Co-authored-by: Paul Bellamy <paul@stellar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants