Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update blas/ext/base/ssortins to follow current project conventions #2917

Merged
merged 11 commits into from
Sep 21, 2024

Conversation

aayush0325
Copy link
Contributor

Resolves #1538 .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Open to reviews and willing to work on this if something else was expected from this PR!

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 17, 2024
@aayush0325 aayush0325 changed the title refactor blas/ext/base/ssortins to follow current project conventions refactor: update blas/ext/base/ssortins to follow current project conventions Sep 17, 2024
@aayush0325
Copy link
Contributor Author

aayush0325 commented Sep 17, 2024

@Planeshifter ready for initial review!

@aayush0325
Copy link
Contributor Author

this branch has a lot of garbage commits which i made while trying to figure things out, i can raise a new, clean PR from another branch if needed.

@kgryte kgryte added the Needs Review A pull request which needs code review. label Sep 21, 2024
@Planeshifter
Copy link
Member

@aayush0325 No reason to worry about the commits, we are squashing the commits anyway when merging PRs to ensure a clean git history. I just did a review and made a few changes, but overall your PR looked great! Thanks for your contribution!

@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Sep 21, 2024
@aayush0325
Copy link
Contributor Author

Thank you for you help and support!

@Planeshifter Planeshifter merged commit 0b47144 into stdlib-js:develop Sep 21, 2024
10 checks passed
@aayush0325 aayush0325 deleted the patch-1 branch September 21, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssortins to follow current project conventions
4 participants