refactor: update implementation in accordance with current project co…

…nventions Ref: #788
stdlib-js · Dec 1, 2023 · 5b15c96 · 5b15c96
1 parent 8e56b51
commit 5b15c96
Show file tree

Hide file tree

Showing 16 changed files with 286 additions and 363 deletions.
diff --git a/lib/node_modules/@stdlib/blas/base/dasum/README.md b/lib/node_modules/@stdlib/blas/base/dasum/README.md
@@ -74,14 +74,10 @@ The `N` and `stride` parameters determine which elements in `x` are used to comp
 
 ```javascript
 var Float64Array = require( '@stdlib/array/float64' );
-var floor = require( '@stdlib/math/base/special/floor' );
 
 var x = new Float64Array( [ -2.0, 1.0, 3.0, -5.0, 4.0, 0.0, -1.0, -3.0 ] );
 
-var N = floor( x.length / 2 );
-var stride = 2;
-
-var sum = dasum( N, x, stride );
+var sum = dasum( 4, x, 2 );
 // returns 10.0
 ```
 
@@ -96,10 +92,8 @@ var x0 = new Float64Array( [ 1.0, -2.0, 3.0, -4.0, 5.0, -6.0 ] );
 // Create an offset view...
 var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element
 
-var N = 3;
-
 // Sum every other value...
-var sum = dasum( N, x1, 2 );
+var sum = dasum( 3, x1, 2 );
 // returns 12.0
 ```
 
@@ -159,28 +153,15 @@ sum = dasum.ndarray( 3, x, -1, x.length-1 );
 <!-- eslint no-undef: "error" -->
 
 ```javascript
-var round = require( '@stdlib/math/base/special/round' );
-var randu = require( '@stdlib/random/base/randu' );
-var Float64Array = require( '@stdlib/array/float64' );
+var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory;
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var dasum = require( '@stdlib/blas/base/dasum' );
 
-var rand;
-var sign;
-var x;
-var i;
-
-x = new Float64Array( 100 );
-for ( i = 0; i < x.length; i++ ) {
-    rand = round( randu()*100.0 );
-    sign = randu();
-    if ( sign < 0.5 ) {
-        sign = -1.0;
-    } else {
-        sign = 1.0;
-    }
-    x[ i ] = sign * rand;
-}
-console.log( dasum( x.length, x, 1 ) );
+var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) );
+console.log( x );
+
+var y = dasum( x.length, x, 1 );
+console.log( y );
 ```
 
 </section>

diff --git a/lib/node_modules/@stdlib/blas/base/dasum/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/base/dasum/benchmark/benchmark.js
@@ -21,14 +21,19 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' ).factory;
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
-var Float64Array = require( '@stdlib/array/float64' );
 var pkg = require( './../package.json' ).name;
 var dasum = require( './../lib/dasum.js' );
 
 
+// VARIABLES //
+
+var rand = uniform( -100.0, 100.0 );
+
+
 // FUNCTIONS //
 
 /**
@@ -39,13 +44,7 @@ var dasum = require( './../lib/dasum.js' );
 * @returns {Function} benchmark function
 */
 function createBenchmark( len ) {
-	var x;
-	var i;
-
-	x = new Float64Array( len );
-	for ( i = 0; i < x.length; i++ ) {
-		x[ i ] = ( randu()*20000.0 ) - 10000.0;
-	}
+	var x = filledarrayBy( len, 'float64', rand );
 	return benchmark;
 
 	/**

diff --git a/lib/node_modules/@stdlib/blas/base/dasum/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/base/dasum/benchmark/benchmark.native.js
@@ -22,10 +22,10 @@
 
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' ).factory;
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
-var Float64Array = require( '@stdlib/array/float64' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
 
@@ -36,6 +36,7 @@ var dasum = tryRequire( resolve( __dirname, './../lib/dasum.native.js' ) );
 var opts = {
 	'skip': ( dasum instanceof Error )
 };
+var rand = uniform( -100.0, 100.0 );
 
 
 // FUNCTIONS //
@@ -48,13 +49,7 @@ var opts = {
 * @returns {Function} benchmark function
 */
 function createBenchmark( len ) {
-	var x;
-	var i;
-
-	x = new Float64Array( len );
-	for ( i = 0; i < x.length; i++ ) {
-		x[ i ] = ( randu()*20000.0 ) - 10000.0;
-	}
+	var x = filledarrayBy( len, 'float64', rand );
 	return benchmark;
 
 	/**

diff --git a/lib/node_modules/@stdlib/blas/base/dasum/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/base/dasum/benchmark/benchmark.ndarray.js
@@ -21,14 +21,19 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' ).factory;
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
-var Float64Array = require( '@stdlib/array/float64' );
 var pkg = require( './../package.json' ).name;
 var dasum = require( './../lib/ndarray.js' );
 
 
+// VARIABLES //
+
+var rand = uniform( -100.0, 100.0 );
+
+
 // FUNCTIONS //
 
 /**
@@ -39,13 +44,7 @@ var dasum = require( './../lib/ndarray.js' );
 * @returns {Function} benchmark function
 */
 function createBenchmark( len ) {
-	var x;
-	var i;
-
-	x = new Float64Array( len );
-	for ( i = 0; i < x.length; i++ ) {
-		x[ i ] = ( randu()*20000.0 ) - 10000.0;
-	}
+	var x = filledarrayBy( len, 'float64', rand );
 	return benchmark;
 
 	/**

diff --git a/lib/node_modules/@stdlib/blas/base/dasum/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/base/dasum/benchmark/benchmark.ndarray.native.js
@@ -22,10 +22,10 @@
 
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' ).factory;
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
-var Float64Array = require( '@stdlib/array/float64' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
 
@@ -36,6 +36,7 @@ var dasum = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) );
 var opts = {
 	'skip': ( dasum instanceof Error )
 };
+var rand = uniform( -100.0, 100.0 );
 
 
 // FUNCTIONS //
@@ -48,13 +49,7 @@ var opts = {
 * @returns {Function} benchmark function
 */
 function createBenchmark( len ) {
-	var x;
-	var i;
-
-	x = new Float64Array( len );
-	for ( i = 0; i < x.length; i++ ) {
-		x[ i ] = ( randu()*20000.0 ) - 10000.0;
-	}
+	var x = filledarrayBy( len, 'float64', rand );
 	return benchmark;
 
 	/**

diff --git a/lib/node_modules/@stdlib/blas/base/dasum/examples/index.js b/lib/node_modules/@stdlib/blas/base/dasum/examples/index.js
@@ -18,25 +18,12 @@
 
 'use strict';
 
-var round = require( '@stdlib/math/base/special/round' );
-var randu = require( '@stdlib/random/base/randu' );
-var Float64Array = require( '@stdlib/array/float64' );
+var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory;
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var dasum = require( './../lib' );
 
-var rand;
-var sign;
-var x;
-var i;
+var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) );
+console.log( x );
 
-x = new Float64Array( 100 );
-for ( i = 0; i < x.length; i++ ) {
-	rand = round( randu()*100.0 );
-	sign = randu();
-	if ( sign < 0.5 ) {
-		sign = -1.0;
-	} else {
-		sign = 1.0;
-	}
-	x[ i ] = sign * rand;
-}
-console.log( dasum( x.length, x, 1 ) );
+var y = dasum( x.length, x, 1 );
+console.log( y );
diff --git a/lib/node_modules/@stdlib/blas/base/dasum/include.gypi b/lib/node_modules/@stdlib/blas/base/dasum/include.gypi
@@ -52,7 +52,7 @@
 
     # Source files:
     'src_files': [
-      '<(src_dir)/addon.cpp',
+      '<(src_dir)/addon.c',
       '<!@(node -e "var arr = require(\'@stdlib/utils/library-manifest\')(\'./manifest.json\',{\'os\':\'<(OS)\',\'blas\':\'<(blas)\'},{\'basedir\':process.cwd(),\'paths\':\'posix\'}).src; for ( var i = 0; i < arr.length; i++ ) { console.log( arr[ i ] ); }")',
     ],
 

diff --git a/lib/node_modules/@stdlib/blas/base/dasum/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/base/dasum/lib/ndarray.native.js
@@ -20,7 +20,8 @@
 
 // MODULES //
 
-var Float64Array = require( '@stdlib/array/float64' );
+var minViewBufferIndex = require( '@stdlib/strided/base/min-view-buffer-index' );
+var offsetView = require( '@stdlib/strided/base/offset-view' );
 var addon = require( './dasum.native.js' );
 
 
@@ -45,11 +46,11 @@ var addon = require( './dasum.native.js' );
 */
 function dasum( N, x, stride, offset ) {
 	var view;
+	offset = minViewBufferIndex( N, stride, offset );
 	if ( stride < 0 ) {
 		stride *= -1;
-		offset -= (N-1) * stride;
 	}
-	view = new Float64Array( x.buffer, x.byteOffset+(x.BYTES_PER_ELEMENT*offset), x.length-offset ); // eslint-disable-line max-len
+	view = offsetView( x, offset );
 	return addon( N, view, stride );
 }